Fix property mapping text box #195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note this sets svelte back on legacy mode but it does fixes the immediate problem until a more future proof solution can be found. |
|
I would prefer to properly update the components to svelte 5 and not run in legacy mode. Do you want to tackle this? |
|
I'm definitely willing to attempt it but I can't promise I'll succeed. If I can't do it I'll let you know |
|
Is this a good enough fix? It's in runes mode and in tests it correctly updates both in the UI and in data.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed
Propsinterface and just used export instead, fixes #191.