Rewrite #17
Rewrite #17
Conversation
chore: man headbutts rock, head hurts
| <Line data={mappedData} x="date" y="downloads" stroke="id" marker={showDots ? 'dot' : undefined} /> | ||
| <Pointer data={mappedData} x="date" z="id" maxDistance={30}> | ||
| {#snippet children({ data })} | ||
| <Text {data} fill="id" x="date" y="downloads" text={d => d.downloads.toFixed()} lineAnchor="bottom" dy={-7} /> |
There was a problem hiding this comment.
(Applies to all graphs)
It would be nice if the tooltip had some kind of semi-transparent background, visibility is sometimes kind of poor
|
|
||
| const { dataPoints, type }: Props = $props(); | ||
|
|
||
| const mappedDataPoints = dataPoints |
There was a problem hiding this comment.
I'm not sure if this is just on my end, but the chart includes the August month with 0 plugins. In this case, it might be better to just exclude it from the view?
| percent100={totalPluginCount} | ||
| client:only="svelte" | ||
| /> | ||
| <BarChart dataPoints={licenseDataPoints.licenses} xLabel="License" yLabel="Number of Plugins" skewLabels hideBarValues client:only="svelte" /> |
There was a problem hiding this comment.
I feel like it would make more sense to have this charts be percentages, rather than absolute amounts, just like the repository data. Idem for all subsequent barcharts.
(Or use absolute values instead of percentages for repository data)
| @@ -1,7 +1,12 @@ | |||
| --- | |||
| import StarlightPage from '@astrojs/starlight/components/StarlightPage.astro'; | |||
| import ThemesIndex from '../../components/svelte/indexPages/themesIndex.svelte'; | |||
There was a problem hiding this comment.
Couldn't test, got a WASM error when loading the page, and I think theme required data was not included. I tried but failed to fetch the theme data myself (I assume I had to clone all themes first?)
If it helps, I got this trace:
Empty theme list at commit 2b64fc20c968b850288bfbc2b99f843f1d7f7f43 (2024-10-31)
Empty theme list at commit 9cbe6f390717d90c4fb6d834121f987cf6ad2184 (2024-04-05)
Empty theme list at commit 9333f0e4b144ae9af0431a7a3916cf7ca6ea8787 (2023-12-29)
Get theme lists: 64.4503ms
Building theme data...
thread 'main' panicked at src\theme\data.rs:64:5:
No theme lists found
(For now, I'll assume the theme pages look great! 😄)
There was a problem hiding this comment.
Strange. The theme data should be included in the repo. And the data extraction script should not fail.
Rewrites the data collection to Rust and switches plotting lib.