Skip to content

Return channel weights #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 35 commits into
base: master
Choose a base branch
from
Draft

Return channel weights #1028

wants to merge 35 commits into from

Conversation

roiser
Copy link
Member

@roiser roiser commented Apr 2, 2025 •
edited
Loading

Return the channel weights from the kernel, the following changes were done

  • numerators in CPPProcess have become an array of size nevents * ndigrams (not every diagram contains the calculation of enumerators / denominators, so we can optimize the size here)
  • the numerator[channelId] is then collected after each diagram
  • related, the kernelAccess (MemoryAccessGs.h) contains a new function to return a pointer (instead of a ref)
  • In CPPProcess the access to the channelId has been refactored into a dedicated function (getChannelId) because the channelId is also needed at the bottom now where the correct numerator[channelId] needs to be chosen

NB for the fun of it I asked copilot to review aswell, @oliviermattelaer you are not off the hook ;-)

Copilot
Copilot AI reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Qubitol Qubitol changed the base branch from return_weights to master April 3, 2025 12:31
@roiser roiser marked this pull request as draft April 3, 2025 13:56
roiser and others added 17 commits April 3, 2025 17:38
@roiser
fix getChannelId for cuda
f14d0d5
@roiser
fix indentation
ebc6bdb
@roiser
C++ starts counting at 0 ;-)
ab338f7
@zeniheisser @roiser
added some verbose/debug flags, disabled FPE traps by default
a041e62
@zeniheisser @roiser
added mod tag and date
f2eff61
@zeniheisser @roiser
lorem ipsum
21b75f5
@roiser
move submodule to 3.6.2
8fb363a
@zeniheisser @roiser
fixed bug where precision wasn't passed properly from the run_card
fb557d0
@roiser
trigger CI
dec050d
@roiser
trigger CI 2
90973b4
@roiser
buffer for numerators cannot be aligned, it depends on the number of
34ec964 
diagrams which not necessarily align well
@roiser
Revert "buffer for numerators cannot be aligned, it depends on the nu…
62c204a 
…mber of"

This reverts commit 34ec964.
@roiser
for the CPU version correct the index access, GPU version still needs to
b39e508 
be done
@roiser
change to processConfig for diagram numbers
0701742
@roiser
change to processConfig for diagram numbers
557b125
@roiser
change to processConfig for diagram numbers
5e1b675
@roiser
fix formatting
13fcd5e
@roiser
Copy link
Member Author

roiser commented Jun 3, 2025

thanks @theoheimel for pointing out the issue in 0c78649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@oliviermattelaer oliviermattelaer Awaiting requested review from oliviermattelaer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roiser @zeniheisser