Run CI also on AMD GPUs from NGT #1042
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some systems may have the command <vendor>-smi installed but that can not communicate with the hardware. In such cases, it is not enough to check the existence of the command itself, but we need to check its exit code.
The old regex was good only for output commands with more than 3 regex words, because of an explicit space to match. Made it lazy.
|
Needed to regenerate the various processes because of all the modifications in the Makefiles for AMD (including some modifications introduced in these commits). Incidentally, I needed to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate the GPU job to run also on AMD GPUs provided through NGT.