Skip to content

feat(cronjob): add resources and nodeSelector #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+23 −1
Open

feat(cronjob): add resources and nodeSelector #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b45b5ce
feat(cronjob): add resources and nodeSelector
fe80 Sep 25, 2025
094c304
feat(cronjob): add ttlSecondsAfterFinished
fe80 Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions charts/mageai/templates/cleanup-cronjob.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ spec:
schedule: {{ .Values.cleanupJob.schedule_cron | default "0 * * * *" | quote }}
jobTemplate:
spec:
{{- if .Values.cleanupJob.ttlSecondsAfterFinished }}
ttlSecondsAfterFinished: {{ .Values.cleanupJob.ttlSecondsAfterFinished }}
{{- end }}
template:
spec:
containers:
Expand Down Expand Up @@ -37,6 +40,12 @@ spec:
{{- toYaml .Values.extraVolumeMounts | nindent 16 }}
{{- end }}
restartPolicy: OnFailure
resources:
{{- toYaml .Values.cleanupJob.resources | nindent 12 }}
{{- with .Values.cleanupJob.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 12 }}
{{- end }}
volumes:
{{- if .Values.volumes }}
{{- toYaml .Values.volumes | nindent 12 }}
Expand Down
15 changes: 14 additions & 1 deletion charts/mageai/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,20 @@ extraEnvs:
fieldPath: metadata.namespace

cleanupJob:
enabled: false
enabled: true
clean_variable_cli_args: ""
clean_log_cli_args: ""
schedule_cron: "0 * * * *" # Runs every hour
ttlSecondsAfterFinished: ~
resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious # W: comment not indente…
# choice for the user. This also increases chances charts run on environments with little
# resources, such as Minikube. If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi
nodeSelector: {}