Skip to content

Conversation

matrixstone
Copy link
Collaborator

Description

Copy the croniter library into the shared repository following the bug report: mage-ai/mage-ai#5684, as it will no longer be maintained.

How Has This Been Tested?

Unit test passed:

test_scheduler:
unit test

test_croniter:
test_croniter

Tested schedule run in Mage UI:
schedule run

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

cc:
@wangxiaoyou1993

@matrixstone matrixstone added the bug Something isn't working label Feb 21, 2025
@matrixstone matrixstone force-pushed the xu-cron branch 2 times, most recently from 2a92ceb to 0a63908 Compare March 1, 2025 20:25
Copy link
Member

@wangxiaoyou1993 wangxiaoyou1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve the conflict? Then we can merge it

@matrixstone matrixstone merged commit 9f952f8 into mage-ai:master Sep 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants