MC-5824: Remove data migration from main Page Builder module

- Fix static failures

Author: davemacaulay

app/code/Magento/PageBuilder/composer.json

@@ -3,6 +3,8 @@
     "description": "Page Builder module",
     "require": {
         "magento/framework": "*",
+        "magento/module-eav": "*",
+        "magento/module-search": "*",
         "magento/module-store": "*",
         "magento/module-backend": "*",
         "magento/module-cms": "*",

app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/BlueFootToPageBuilder.php

@@ -10,6 +10,8 @@
 use Magento\Framework\DB\DataConverter\DataConverterInterface;
 
 /**
+ * Class BlueFootToPageBuilder
+ *
  * Convert existing BlueFoot 1.0.* structures into Magento PageBuilder compatible HTML structures. This is ran on first
  * install of the new Page Builder module. It will leave any unsupported content in the tree allowing the
  * MixedToPageBuilder process this later on.
@@ -46,7 +48,7 @@ public function __construct(
      * @param string $value
      * @return string
      */
-    public function convert($value)
+    public function convert(string $value)
     {
         if (preg_match('/<!--' . Format::BLUEFOOT_KEY . '="(.*)"-->/', $value, $matches)) {
             if ($this->validator->validate($matches[1])) {

app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/MixedToPageBuilder.php

@@ -10,6 +10,8 @@
 use Magento\Framework\DB\DataConverter\DataConverterInterface;
 
 /**
+ * Class MixedToPageBuilder
+ *
  * Convert mixed PageBuilder & PageBuilder content to Magento PageBuilder compatible HTML structures, this should be
  * utilised for 3rd party extensions outside of core that previously extended PageBuilder's functionality.
  */
@@ -45,7 +47,7 @@ public function __construct(
      * @param string $value
      * @return string
      */
-    public function convert($value)
+    public function convert(string $value)
     {
         if (strstr($value, Format::UNMIGRATED_KEY) !== false) {
             return $this->convertMixed($value);
@@ -57,10 +59,10 @@ public function convert($value)
     /**
      * Convert any instances of un-migrated content to the new format
      *
-     * @param $value
+     * @param string $value
      * @return string
      */
-    private function convertMixed($value)
+    private function convertMixed(string $value)
     {
         /**
          * Match all instances of any un-migrated content within the value argument. This will automatically retrieve

dev/tests/static/testsuite/Magento/Test/Integrity/_files/blacklist/composer_root_modules_pagebuilder.txt

@@ -1,2 +1,3 @@
 magento/module-page-builder
-magento/module-page-builder-analytics
+magento/module-page-builder-analytics
+magento/module-page-builder-data-migration