MC-5824: Remove data migration from main Page Builder module

davemacaulay · davemacaulay · commit d8cae2b7e104 · 2019-01-22T11:16:29.000+01:00
- Fix introduction of string type within converter
diff --git a/app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/BlueFootToPageBuilder.php b/app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/BlueFootToPageBuilder.php
@@ -48,7 +48,7 @@ public function __construct(
      * @param string $value
      * @return string
      */
-    public function convert(string $value)
+    public function convert($value)
     {
         if (preg_match('/<!--' . Format::BLUEFOOT_KEY . '="(.*)"-->/', $value, $matches)) {
             if ($this->validator->validate($matches[1])) {
diff --git a/app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/MixedToPageBuilder.php b/app/code/Magento/PageBuilderDataMigration/Setup/DataConverter/MixedToPageBuilder.php
@@ -47,7 +47,7 @@ public function __construct(
      * @param string $value
      * @return string
      */
-    public function convert(string $value)
+    public function convert($value)
     {
         if (strstr($value, Format::UNMIGRATED_KEY) !== false) {
             return $this->convertMixed($value);

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public function __construct(`
`48`	`48`	`* @param string $value`
`49`	`49`	`* @return string`
`50`	`50`	`*/`
`51`		`- public function convert(string $value)`
	`51`	`+ public function convert($value)`
`52`	`52`	`{`
`53`	`53`	`if (preg_match('/<!--' . Format::BLUEFOOT_KEY . '="(.*)"-->/', $value, $matches)) {`
`54`	`54`	`if ($this->validator->validate($matches[1])) {`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function __construct(`
`47`	`47`	`* @param string $value`
`48`	`48`	`* @return string`
`49`	`49`	`*/`
`50`		`- public function convert(string $value)`
	`50`	`+ public function convert($value)`
`51`	`51`	`{`
`52`	`52`	`if (strstr($value, Format::UNMIGRATED_KEY) !== false) {`
`53`	`53`	`return $this->convertMixed($value);`