Several fixes #854
Merged
Several fixes #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `wsrep_causal_reads` variable has been deprecated in newer versions of Galera Cluster and replaced with `wsrep_sync_wait`. This change updates the `mysqltuner.pl` script to handle both variables gracefully. The script now checks for `wsrep_causal_reads` first, and if it's not defined, it falls back to checking for `wsrep_sync_wait`. This ensures that the script provides accurate information for different Galera versions without producing warnings for uninitialized variables. Additionally, this change includes minor code quality improvements identified by `perlcritic`, such as using `IO::Interactive` for checking terminal interactivity and using lexical filehandles.
The recommendation for innodb_buffer_pool_instances is now capped by the number of CPU cores. This prevents recommending a value that is too high for the available hardware, which is a common performance pitfall. An informational message is displayed when the recommendation is capped by the CPU core count.
The `wsrep_causal_reads` variable has been deprecated in newer versions of Galera Cluster and replaced with `wsrep_sync_wait`. This change updates the `mysqltuner.pl` script to handle both variables gracefully. The script now checks for `wsrep_causal_reads` first, and if it's not defined, it falls back to checking for `wsrep_sync_wait`. This ensures that the script provides accurate information for different Galera versions without producing warnings for uninitialized variables.
Fix uninitialized value warning for wsrep_causal_reads
…iaDB. A new subroutine, `mariadb_query_cache_info`, has been added to check for the presence and status of the `QUERY_CACHE_INFO` plugin. If the plugin is active, the script will now display the contents of the `information_schema.query_cache_info` table, providing insights into the queries currently held in the query cache. This feature is specific to MariaDB and will be skipped on other MySQL-based systems.
…nces Improve innodb_buffer_pool_instances recommendation
feat: Add Query Cache Info plugin support for MariaDB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wsrep_slave_threads deprecated in mySQL 8.0+
#819 In major/MySQLTuner-perl;· nblount opened on Feb 9
Uninitialized value error wsrep_causal_reads (MySQL8.3 and Galera4)
#818 In major/MySQLTuner-perl;· nblount opened on Feb 9
PASSWORD() function used on 8.0
#815 In major/MySQLTuner-perl;· fmonts opened on Jan 11
innodb_buffer_pool_instances suggestion
#811 In major/MySQLTuner-perl;· PRR24 opened on Dec 15, 2024