Skip to content

adp/adp.cpp: add nvram to funny land #14048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

stonedDiscord
Copy link
Contributor

Function 188dc in funlddlx4 will initialize the NVRAM and make the machine boot.

There's still issues with the inputs so it stays as MACHINE_NOT_WORKING

@stonedDiscord stonedDiscord marked this pull request as ready for review August 12, 2025 17:35
Copy link
Member

@cuavas cuavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this default NVRAM taken from a real machine, or handcrafted to look like what the program expects? For the systems where it says the NVRAM content is “taken from parent”, should it have the BAD_DUMP flag until it’s verified that the same content is OK for the clones?

@stonedDiscord
Copy link
Contributor Author

It's crafted by running the initialization routine in the emulated system.
In my tests the clones generated the same NVRAM.
The difference between the clones seem to be the switch in currency from DM to €

@cuavas
Copy link
Member

cuavas commented Aug 12, 2025

Can you note that it’s just default initialisation the program generates for convenience, and not required factory initialisation content?

@stonedDiscord
Copy link
Contributor Author

Where should I put the comment? In the header or next to the ROM loads?

The RAMs are blank in the factory and get initialized using the service keyboard (adp/servicet.cpp) which ends up calling 188dc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants