ci: ignore pyasn1 major updates to prevent vivisect breaks#2899
ci: ignore pyasn1 major updates to prevent vivisect breaks#2899MShantanu110 wants to merge 1 commit intomandiant:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves persistent CI failures by preventing Dependabot from proposing major version updates for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the dependabot configuration to ignore updates for pyasn1 version 0.6.0 and higher, which is causing CI breaks. The change is correct for the stated purpose. However, it also removes a rule that was ignoring all patch-level updates for all dependencies. I've added a comment to highlight this side-effect and suggested a modification to make the intent clearer and avoid a potential flood of new dependabot PRs if this was unintentional.
| - dependency-name: "pyasn1" | ||
| versions: ">= 0.6.0" |
There was a problem hiding this comment.
This change also removes the rule to ignore all patch-level updates. This is a significant change that will re-enable patch updates for all dependencies, potentially leading to a large number of new pull requests from Dependabot. While enabling patch updates is a good practice, the PR description only mentions ignoring pyasn1. To avoid unintended side-effects, consider keeping both ignore rules if the goal was only to address the pyasn1 issue.
- dependency-name: "pyasn1"
versions: ">= 0.6.0"
- dependency-name: "*"
update-types: ["version-update:semver-patch"]1 participant
Description
Discussion in the issue, grouping
vivisectandpyasn1in the Dependabot config wasn't enough to stop the CI breaks becausevivisecthasn't caught up to the breaking changes inpyasn10.6.x yet.Instead of hardcoding project metadata or adding custom
pip checkpipeline steps which adds technical debt, this PR simply adds anignorerule forpyasn1 >= 0.6.0to the.github/dependabot.ymlfile. This is a clean, minimal fix that respects the existing dependency boundaries and stops the CI from failing on versionsvivisectcan't support yet.closes #2826
Checklist