Change capa-rules version in installation guide#2965
Change capa-rules version in installation guide#2965eversinc33 wants to merge 1 commit intomandiant:masterfrom
Conversation
Updated the installation instructions to reflect the newest version of capa-rules.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue in the installation guide where an outdated version of Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
CHANGELOG updated or no update needed, thanks! 😄
There was a problem hiding this comment.
Code Review
This pull request updates the capa-rules version in the installation documentation from v4.0.0 to v9.3.1. The review suggests an improvement to the installation instructions by making the example capa command more specific, using the actual directory name created after unzipping the rules, rather than a generic placeholder, to enhance clarity for users.
| $ wget https://github.com/mandiant/capa-rules/archive/refs/tags/v9.3.1.zip | ||
| $ unzip v9.3.1.zip |
There was a problem hiding this comment.
The version update is correct. For improved clarity, consider also updating the example capa command on the next line. Unzipping v9.3.1.zip creates a directory named capa-rules-9.3.1. Using this specific path in the example command instead of the generic placeholder /path/to/capa-rules would make the instructions easier to follow.
A suggested change for lines 33-35 would be:
$ wget https://github.com/mandiant/capa-rules/archive/refs/tags/v9.3.1.zip
$ unzip v9.3.1.zip
$ capa -r capa-rules-9.3.1/ suspicious.exeWhile this change extends beyond the current diff, it would significantly improve the user experience.
Updated the installation instructions to reflect the newest version of capa-rules.
The old version 4.0.0 that was listed isn't even supported anymore, so following the guide does not lead to being able to run capa.
Checklist