Skip to content

Conversation

Floppy
Copy link
Collaborator

@Floppy Floppy commented Apr 17, 2025

This is safer, and has a less confusing UI. Only thing is, will people mind?

This will mean that all model folders will be given an ID like #2435 at the end of their folder name when reorganized. This is recommended at the moment, but this change makes it non-configurable.

Definitely want feedback from people who are highly opinionated about their folder structures before I merge this. Let me know what you think.

@Floppy Floppy added improvement Refactors and behind-the-scenes improvements breaking change This breaks compatibility, or removes a feature labels Apr 17, 2025
safer, less confusing UI. Only thing is, will people mind?
@Floppy Floppy force-pushed the always-add-modelId branch from 21fb31f to 8ef31ee Compare April 17, 2025 11:04
@Floppy Floppy added help wanted Extra attention is needed question Further information is requested labels Apr 17, 2025
@matthewbadeau
Copy link
Collaborator

For multiuser servers this will help make sure there are no naming collisions. Even if an admin accidentally changes the organization settings. So I like the change for this reason.

For single user systems, this might break pre-existing naming conventions for people that prefer Manyfold to not touch the filesystem at all. I don't know how many people are in this camp though. Manyfold already makes some changes to the filesystem though, so I don't know how much of a worry this will be.

I'm hoping others can weigh in here.

@Floppy
Copy link
Collaborator Author

Floppy commented Apr 18, 2025

Yeah, I'm hoping that talking through this a bit will help lead me to some solution that works for both cases. In fact, your comment has made me wonder if "don't change the folders ever" is a good setting to have that might make all this clearer.

@Floppy
Copy link
Collaborator Author

Floppy commented Apr 18, 2025

In fact... yes... we have an issue for auto-organise, perhaps that just becomes a setting for "reorganise folders" with the options "auto", "manual" (current behaviour, perhaps plus fully editable path?), and "never". It would still need to auto organise uploads, though if path editing was available then maybe that would be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change This breaks compatibility, or removes a feature help wanted Extra attention is needed improvement Refactors and behind-the-scenes improvements question Further information is requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants