Open
Conversation
0fd5531 to
315b593
Compare
commit: |
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
Herb::Engineto have the ability to automatically close omitted HTML closing tags when compiling and rendering templates by introducing a newauto_close_omitted_tagsoption.While you are able to omit certain HTML closing tags according to the spec, it can be a bit misleading and confusing to do so. That's why Herb encourages to always close all HTML elements, even if they could be omitted.
This new
auto_close_omitted_tagsoption now allows the templates to remain as they are, but to make sure that the rendered output of the engine is always "fully conforming" to have a closing tag in the rendered output.For example, this template:
This gets compiled as:
herb compile test.html.erb --no-strict --auto-close-tagsAnd rendered as:
exe/herb render test.html.erb --no-strict --auto-close-tagsBuilds on top of #1173