-
-
Notifications
You must be signed in to change notification settings - Fork 10
Further development following the idea of custom row builder. Writing export-tools. #5
base: master
Are you sure you want to change the base?
Conversation
with I). Created a BasicDataRowBuilder as a Super-class for custom rowbuilder. Unfortunately there was a lot of whitespace-changes.
an DataSetRowChanger.
Thanks for your pull request, @opensource21. A lot of good work there! Regarding the copyright headers: So far this little project is not affiliated with DbUnit in any way. I am not a DbUnit committer, are you? Thus, I would not like to add those headers, yet. BTW, I've tried to get the current code under the dbUnit umbrella here: http://sourceforge.net/p/dbunit/feature-requests/180/ Unfortunately, one would have to submit a patch for Java 6 and JUnit 4.11 there first. I'm not using dbUnit right now. Would you be willing to take this direction and submit such a patch there? |
I added the header to make it easier to create later a pull request, but you are right, it's difficult because we must go back to Java 1.5, which I found too painful or must finish dbunit 3.x work. I was thinking about a project dbunit_ext, where such extensions could be managed. At the end I stoped this direction and only change my code so that it was backward compatible to your branch. I hoped that I can achieve at least, that there not exists 2 datasetbuilder solutions, which makes it difficult for further people to grab it and work on it. BTW: Why you don't use dbUnit anymore? |
While I would prefer getting DataSetBuilder into dbUnit core, your suggestion sounds like a good idea to keep things from getting worse. Let me know about your next steps. Shall we close this pull request?
I don't have a need for it in my current project. We use Hibernate for persistence and don't have too many complicated SQL queries. |
At the weekend I tried to forked the dbunit-git-repository. Unfortunately, I got an error from SF. So I do it old school, clone, branch and create patch-files. One for java5 and one for junit 4. I will see what happens. Would be great if dbunit code would be hosted at github and get more contributions. I dislike the idea that each person writes some wrappers. I would let the pull request open as long as the situation isn't clarified. |
@opensource21 I've create a separate issue to track progress on getting dbUnit integrated into dbUnit core over at #6. Let's continue the discussion there. |
1584b7b
to
f1db498
Compare
Adjust the code so taht it's more DBUnit like (Header, Interfaces starts with I).
Created a BasicDataRowBuilder as a Super-class for custom rowbuilder.
Unfortunately there was a lot of whitespace-changes.
Create BuilderDataSetWriter and CustomRowBuilderGenerator together with
an DataSetRowChanger.