Skip to content

feat: Add title field support for human-friendly display names #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davidleitw
Copy link
Contributor

@davidleitw davidleitw commented Jun 21, 2025

Add Title Field Support for Human-Friendly Display Names

  • Implement BaseMetadata interface for consistent title handling
  • Add Title field to Tool, Prompt, Resource, ResourceTemplate
  • Add GetDisplayName() helper with title → annotations.title → name fallback
  • Add WithTitle/WithPromptTitle/WithResourceTitle/WithTemplateTitle options
  • Fix Tool JSON serialization to include title field
  • Add comprehensive tests and update examples
  • Fully backward compatible

Resolves #418

Description

This PR implements Task #418 by adding comprehensive title field support across all MCP object types to provide human-friendly display names while maintaining programmatic identification through the existing name fields.

What We've Implemented

Core Infrastructure:

  • Created BaseMetadata interface with GetName() and GetTitle() methods for consistent behavior across all types
  • Added GetDisplayName() helper function that implements the fallback logic: title → annotations.title → name
  • All MCP object types (Tool, Prompt, Resource, ResourceTemplate) now implement this interface

Title Field Support:

  • Added Title field to all relevant structs with json:"title,omitempty" for optional serialization
  • Tool supports the full fallback chain: direct title → annotations.title → name
  • Other types (Prompt, Resource, ResourceTemplate) support: title → name fallback

API Enhancements:

  • WithTitle() - Configure Tool title (takes precedence over annotation title)
  • WithPromptTitle() - Configure Prompt title
  • WithResourceTitle() - Configure Resource title
  • WithTemplateTitle() - Configure ResourceTemplate title
  • Fixed Tool.MarshalJSON() to properly serialize the title field

Current Behavior

// Tool with multiple title options
tool := NewTool("search-files",
    WithTitle("File Search"),  // Direct title (highest priority)
    WithTitleAnnotation("Legacy Title"), // Annotation title (fallback)
)

// GetDisplayName() returns "File Search" (direct title wins)
displayName := GetDisplayName(&tool)

// Other types with simple title support  
prompt := NewPrompt("user-prompt", WithPromptTitle("User Input Prompt"))
resource := NewResource("/api/data", "api-data", WithResourceTitle("API Data"))

Fallback Priority:

  1. Tool: titleannotations.titlename
  2. Others: titlename

Testing & Compatibility

  • Added comprehensive test suite covering all types and fallback scenarios
  • Updated all examples to demonstrate title usage
  • 100% backward compatible - existing code works unchanged
  • All title fields are optional and won't affect existing JSON serialization

Fixes #418

Type of Change

  • New feature (non-breaking change that adds functionality)
  • MCP spec compatibility implementation
  • Bug fix (non-breaking change that fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Tests only (no functional changes)
  • Other (please describe):

Checklist

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the documentation accordingly

MCP Spec Compliance

  • Implementation follows the specification exactly

Additional Information

Design Decisions:

  • Chose to implement BaseMetadata interface for consistency rather than individual methods per type
  • Tool maintains backward compatibility with existing annotations.title while adding direct title support
  • Used functional options pattern to maintain API consistency with existing codebase

Testing Coverage:

  • Interface compliance tests ensure all types implement BaseMetadata
  • Fallback logic tests for each type and scenario
  • JSON serialization/deserialization tests for Tool (most complex case)
  • All tests pass and maintain existing functionality

This implementation provides a clean foundation for human-readable display names across the MCP ecosystem. Any feedback on the design approach, additional test scenarios, or edge cases would be greatly appreciated. Thank you for taking the time to review this PR!

Summary by CodeRabbit

  • New Features

    • Added support for human-friendly display titles to tools, prompts, resources, and resource templates.
    • Display titles can now be set via new options and appear in JSON output where applicable.
    • Introduced a unified method to retrieve display names across these entities.
    • Updated example tools and resources with descriptive titles for better clarity.
  • Tests

    • Added tests to verify display name retrieval and JSON serialization of titles.

- Implement BaseMetadata interface for consistent title handling
- Add Title field to Tool, Prompt, Resource, ResourceTemplate
- Add GetDisplayName() helper with title → annotations.title → name fallback
- Add WithTitle/WithPromptTitle/WithResourceTitle/WithTemplateTitle options
- Fix Tool JSON serialization to include title field
- Add comprehensive tests and update examples
- Fully backward compatible

Resolves Task mark3labs#418
Copy link
Contributor

coderabbitai bot commented Jun 21, 2025

Walkthrough

The changes introduce a new optional Title field to several core types (Tool, Prompt, Resource, ResourceTemplate) to support human-friendly display names. Corresponding getter methods, functional options, and a BaseMetadata interface are added. Display name precedence logic and helper utilities are implemented, alongside comprehensive tests.

Changes

Files / Grouped Files Change Summary
mcp/types.go Added Title field and GetTitle() to Resource and ResourceTemplate; introduced BaseMetadata interface.
mcp/prompts.go Added Title field, GetTitle() method, and WithPromptTitle() option to Prompt.
mcp/tools.go Added Title field, GetTitle(), WithTitle() option, and updated JSON marshaling for Tool.
mcp/resources.go Added WithResourceTitle() and WithTemplateTitle() functional options.
mcp/utils.go Added GetDisplayName() utility and interface assertions for BaseMetadata.
mcp/types_test.go Added tests for display name logic and Tool JSON serialization/deserialization.
examples/custom_context/main.go Added Title to "make_authenticated_request" tool.
examples/dynamic_path/main.go Added Title to "echo" tool.
examples/everything/main.go Added Title fields to resources, templates, prompts, and tools; refactored resource creation to use titles.
examples/in_process/main.go Added Title to "dummy_tool" tool.
examples/typed_tools/main.go Added Title to "greeting" tool.

Assessment against linked issues

Objective Addressed Explanation
Create BaseMetadata interface with name and title (#418)
Update Tool, Resource, Prompt, etc. to inherit from BaseMetadata (#418)
Implement display name precedence: titleannotations.titlename (#418)
Add helper functions for getting display names (#418)
Update all examples to include title fields (#418) Titles added to tools, resources, prompts, and templates in multiple example files.

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Possibly related PRs

  • fix: tool annotation #165: Modifies Tool.MarshalJSON to include Annotations and adds test assertions for annotations; related to Tool metadata handling but focuses on annotations rather than Title.

Suggested labels

type: enhancement, area: sdk

Suggested reviewers

  • ezynda3
  • pottekkat

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd458b4 and d60749b.

📒 Files selected for processing (5)
  • examples/custom_context/main.go (1 hunks)
  • examples/dynamic_path/main.go (1 hunks)
  • examples/everything/main.go (6 hunks)
  • examples/in_process/main.go (1 hunks)
  • examples/typed_tools/main.go (1 hunks)
✅ Files skipped from review due to trivial changes (5)
  • examples/typed_tools/main.go
  • examples/in_process/main.go
  • examples/custom_context/main.go
  • examples/dynamic_path/main.go
  • examples/everything/main.go
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: test
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Update all example applications to demonstrate new title functionality:
- custom_context: Add WithTitle for authenticated request tool
- dynamic_path: Add WithTitle for echo tool
- everything: Add comprehensive title support for all resources, prompts, and tools
- in_process: Add WithTitle for dummy tool
- typed_tools: Add WithTitle for greeting tool
Copy link
Collaborator

@pottekkat pottekkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to have different functions like WithResourceTitle, WithPromptTitle, and WithTitle? Seems a bit unnecessary. Can we provide better APIs?

@davidleitw
Copy link
Contributor Author

I feel that, at least for the DisplayName topic, we should try to provide helper functions to make it easier for users. Or do you have any good ideas regarding the API design? I’d be happy to try making some adjustments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Add Title Field for Human-Friendly Display Names
2 participants