-
Notifications
You must be signed in to change notification settings - Fork 704
feat: Implement per-session prompt functionality #459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sebastianripari
wants to merge
15
commits into
mark3labs:main
Choose a base branch
from
sebastianripari:feat_prompts_per_session
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0576cd3
add session with prompts
sebastianripari 5831267
on session prompt list msg set the session prompts
sebastianripari fa887f6
add new error message
sebastianripari 9e18df3
AddSessionPrompts method on Session
sebastianripari da8be7d
start with test, add sessionTestClientWithPrompts struct
sebastianripari 0fbd1d8
add first test AddSessionPrompts
sebastianripari 5f64c16
add new test AddSessionPrompt
sebastianripari 9a1f382
add test GetSessionPrompt
sebastianripari a988d3d
add test AddSessionPromptsUninitialized
sebastianripari 3302f37
add log
sebastianripari 0e24d31
add log
sebastianripari 178bd07
add SessionWithPromps on sse server
sebastianripari 50f4681
remove logrus and edit readme
sebastianripari 5349f38
remove sys
sebastianripari 9339179
fix test
sebastianripari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Document thread-safety requirements for consistency.
The
SessionWithTools
interface above documents thread-safety requirements in its method comments, butSessionWithPrompts
does not. For consistency and to ensure proper implementation, please add similar documentation.📝 Committable suggestion
🤖 Prompt for AI Agents