Skip to content
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions server/inprocess_session.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,14 @@ type SamplingHandler interface {
}

type InProcessSession struct {
sessionID string
notifications chan mcp.JSONRPCNotification
initialized atomic.Bool
loggingLevel atomic.Value
clientInfo atomic.Value
samplingHandler SamplingHandler
mu sync.RWMutex
sessionID string
notifications chan mcp.JSONRPCNotification
initialized atomic.Bool
loggingLevel atomic.Value
clientInfo atomic.Value
clientCapabilities atomic.Value
samplingHandler SamplingHandler
mu sync.RWMutex
}

func NewInProcessSession(sessionID string, samplingHandler SamplingHandler) *InProcessSession {
Expand Down Expand Up @@ -63,6 +64,19 @@ func (s *InProcessSession) SetClientInfo(clientInfo mcp.Implementation) {
s.clientInfo.Store(clientInfo)
}

func (s *InProcessSession) GetClientCapabilities() mcp.ClientCapabilities {
if value := s.clientCapabilities.Load(); value != nil {
if clientCapabilities, ok := value.(mcp.ClientCapabilities); ok {
return clientCapabilities
}
}
return mcp.ClientCapabilities{}
}

func (s *InProcessSession) SetClientCapabilities(clientCapabilities mcp.ClientCapabilities) {
s.clientCapabilities.Store(clientCapabilities)
}

func (s *InProcessSession) SetLogLevel(level mcp.LoggingLevel) {
s.loggingLevel.Store(level)
}
Expand Down
2 changes: 2 additions & 0 deletions server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -583,8 +583,10 @@ func (s *MCPServer) handleInitialize(
// Store client info if the session supports it
if sessionWithClientInfo, ok := session.(SessionWithClientInfo); ok {
sessionWithClientInfo.SetClientInfo(request.Params.ClientInfo)
sessionWithClientInfo.SetClientCapabilities(request.Params.Capabilities)
}
}

return &result, nil
}

Expand Down
4 changes: 4 additions & 0 deletions server/session.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ type SessionWithClientInfo interface {
GetClientInfo() mcp.Implementation
// SetClientInfo sets the client information for this session
SetClientInfo(clientInfo mcp.Implementation)
// GetClientCapabilities returns the client capabilities for this session
GetClientCapabilities() mcp.ClientCapabilities
// SetClientCapabilities sets the client capabilities for this session
SetClientCapabilities(clientCapabilities mcp.ClientCapabilities)
}

// SessionWithStreamableHTTPConfig extends ClientSession to support streamable HTTP transport configurations
Expand Down
26 changes: 24 additions & 2 deletions server/session_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ type sessionTestClientWithClientInfo struct {
notificationChannel chan mcp.JSONRPCNotification
initialized bool
clientInfo atomic.Value
clientCapabilities atomic.Value
}

func (f *sessionTestClientWithClientInfo) SessionID() string {
Expand Down Expand Up @@ -137,6 +138,19 @@ func (f *sessionTestClientWithClientInfo) SetClientInfo(clientInfo mcp.Implement
f.clientInfo.Store(clientInfo)
}

func (f *sessionTestClientWithClientInfo) GetClientCapabilities() mcp.ClientCapabilities {
if value := f.clientCapabilities.Load(); value != nil {
if clientCapabilities, ok := value.(mcp.ClientCapabilities); ok {
return clientCapabilities
}
}
return mcp.ClientCapabilities{}
}

func (f *sessionTestClientWithClientInfo) SetClientCapabilities(clientCapabilities mcp.ClientCapabilities) {
f.clientCapabilities.Store(clientCapabilities)
}

// sessionTestClientWithTools implements the SessionWithLogging interface for testing
type sessionTestClientWithLogging struct {
sessionID string
Expand Down Expand Up @@ -888,7 +902,7 @@ func TestMCPServer_SessionToolCapabilitiesBehavior(t *testing.T) {
validateServer func(t *testing.T, s *MCPServer, session *sessionTestClientWithTools)
}{
{
name: "no tool capabilities provided",
name: "no tool capabilities provided",
serverOptions: []ServerOption{
// No WithToolCapabilities
},
Expand Down Expand Up @@ -1099,10 +1113,14 @@ func TestSessionWithClientInfo_Integration(t *testing.T) {
Version: "1.0.0",
}

clientCapability := mcp.ClientCapabilities{
Sampling: &struct{}{},
}

initRequest := mcp.InitializeRequest{}
initRequest.Params.ClientInfo = clientInfo
initRequest.Params.ProtocolVersion = mcp.LATEST_PROTOCOL_VERSION
initRequest.Params.Capabilities = mcp.ClientCapabilities{}
initRequest.Params.Capabilities = clientCapability

sessionCtx := server.WithContext(context.Background(), session)

Expand All @@ -1125,6 +1143,10 @@ func TestSessionWithClientInfo_Integration(t *testing.T) {

assert.Equal(t, clientInfo.Name, storedClientInfo.Name, "Client name should match")
assert.Equal(t, clientInfo.Version, storedClientInfo.Version, "Client version should match")

storedClientCapabilities := sessionWithClientInfo.GetClientCapabilities()

assert.Equal(t, clientCapability, storedClientCapabilities, "Client capability should match")
}

// New test function to cover log notification functionality
Expand Down
14 changes: 14 additions & 0 deletions server/sse.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ type sseSession struct {
loggingLevel atomic.Value
tools sync.Map // stores session-specific tools
clientInfo atomic.Value // stores session-specific client info
clientCapabilities atomic.Value // stores session-specific client capabilities
}

// SSEContextFunc is a function that takes an existing context and the current
Expand Down Expand Up @@ -108,6 +109,19 @@ func (s *sseSession) SetClientInfo(clientInfo mcp.Implementation) {
s.clientInfo.Store(clientInfo)
}

func (s *sseSession) SetClientCapabilities(clientCapabilities mcp.ClientCapabilities) {
s.clientCapabilities.Store(clientCapabilities)
}

func (s *sseSession) GetClientCapabilities() mcp.ClientCapabilities {
if value := s.clientCapabilities.Load(); value != nil {
if clientCapabilities, ok := value.(mcp.ClientCapabilities); ok {
return clientCapabilities
}
}
return mcp.ClientCapabilities{}
}

var (
_ ClientSession = (*sseSession)(nil)
_ SessionWithTools = (*sseSession)(nil)
Expand Down
32 changes: 23 additions & 9 deletions server/stdio.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,16 @@ func WithStdioContextFunc(fn StdioContextFunc) StdioOption {

// stdioSession is a static client session, since stdio has only one client.
type stdioSession struct {
notifications chan mcp.JSONRPCNotification
initialized atomic.Bool
loggingLevel atomic.Value
clientInfo atomic.Value // stores session-specific client info
writer io.Writer // for sending requests to client
requestID atomic.Int64 // for generating unique request IDs
mu sync.RWMutex // protects writer
pendingRequests map[int64]chan *samplingResponse // for tracking pending sampling requests
pendingMu sync.RWMutex // protects pendingRequests
notifications chan mcp.JSONRPCNotification
initialized atomic.Bool
loggingLevel atomic.Value
clientInfo atomic.Value // stores session-specific client info
clientCapabilities atomic.Value // stores session-specific client capabilities
writer io.Writer // for sending requests to client
requestID atomic.Int64 // for generating unique request IDs
mu sync.RWMutex // protects writer
pendingRequests map[int64]chan *samplingResponse // for tracking pending sampling requests
pendingMu sync.RWMutex // protects pendingRequests
}

// samplingResponse represents a response to a sampling request
Expand Down Expand Up @@ -100,6 +101,19 @@ func (s *stdioSession) SetClientInfo(clientInfo mcp.Implementation) {
s.clientInfo.Store(clientInfo)
}

func (s *stdioSession) GetClientCapabilities() mcp.ClientCapabilities {
if value := s.clientCapabilities.Load(); value != nil {
if clientCapabilities, ok := value.(mcp.ClientCapabilities); ok {
return clientCapabilities
}
}
return mcp.ClientCapabilities{}
}

func (s *stdioSession) SetClientCapabilities(clientCapabilities mcp.ClientCapabilities) {
s.clientCapabilities.Store(clientCapabilities)
}

func (s *stdioSession) SetLogLevel(level mcp.LoggingLevel) {
s.loggingLevel.Store(level)
}
Expand Down
50 changes: 50 additions & 0 deletions www/docs/pages/servers/advanced.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -821,6 +821,56 @@ func startWithGracefulShutdown(s *server.MCPServer) {
}
```

## Client Capability Based Filtering

```go
package main

import (
"context"
"fmt"

"github.com/mark3labs/mcp-go/mcp"
"github.com/mark3labs/mcp-go/server"
)

func main() {
s := server.NewMCPServer("Typed Server", "1.0.0",
server.WithToolCapabilities(true),
)

s.AddTool(
mcp.NewTool("calculate",
mcp.WithDescription("Perform basic mathematical calculations"),
mcp.WithString("operation",
mcp.Required(),
mcp.Enum("add", "subtract", "multiply", "divide"),
mcp.Description("The operation to perform"),
),
mcp.WithNumber("x", mcp.Required(), mcp.Description("First number")),
mcp.WithNumber("y", mcp.Required(), mcp.Description("Second number")),
),
handleCalculate,
)

server.ServeStdio(s)
}

func handleCalculate(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
session := server.ClientSessionFromContext(ctx)
if session == nil {
return nil, fmt.Errorf("no active session")
}

if clientSession, ok := session.(server.SessionWithClientInfo); ok {
clientCapabilities := clientSession.GetClientCapabilities()
if clientCapabilities.Sampling == nil {
fmt.Println("sampling is not enabled in client")
}
}
}
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

handleCalculate can fall through without a return → example will not compile

Go requires every control path in a non-void function to end with a return.
After the capability check the function falls through, triggering:

missing return at end of function

Provide a concrete result (or an explicit TODO) so users can copy-paste the snippet without errors.

 func handleCalculate(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
@@
-        if clientCapabilities.Sampling == nil {
-            fmt.Println("sampling is not enabled in client")
-        }
-    }
-}
+        if clientCapabilities.Sampling == nil {
+            return mcp.NewToolResultError("sampling capability not enabled"), nil
+        }
+    }
+
+    // TODO: implement calculation logic
+    return mcp.NewToolResultError("not implemented"), nil
+}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
func handleCalculate(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
session := server.ClientSessionFromContext(ctx)
if session == nil {
return nil, fmt.Errorf("no active session")
}
if clientSession, ok := session.(server.SessionWithClientInfo); ok {
clientCapabilities := clientSession.GetClientCapabilities()
if clientCapabilities.Sampling == nil {
fmt.Println("sampling is not enabled in client")
}
}
}
```
func handleCalculate(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
session := server.ClientSessionFromContext(ctx)
if session == nil {
return nil, fmt.Errorf("no active session")
}
if clientSession, ok := session.(server.SessionWithClientInfo); ok {
clientCapabilities := clientSession.GetClientCapabilities()
if clientCapabilities.Sampling == nil {
return mcp.NewToolResultError("sampling capability not enabled"), nil
}
}
// TODO: implement calculation logic
return mcp.NewToolResultError("not implemented"), nil
}
🤖 Prompt for AI Agents
In www/docs/pages/servers/advanced.mdx around lines 859 to 872, the function
handleCalculate lacks a return statement on all control paths, causing a
compilation error. Add a return statement at the end of the function that
returns a valid *mcp.CallToolResult and nil error, or include a TODO comment
with a placeholder return to ensure the function always returns a value.


## Sampling (Advanced)

Sampling is an advanced feature that allows servers to request LLM completions from clients. This enables bidirectional communication where servers can leverage client-side LLM capabilities for content generation, reasoning, and question answering.
Expand Down