-
Notifications
You must be signed in to change notification settings - Fork 694
Fix streamable http sampling #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andig
wants to merge
26
commits into
mark3labs:main
Choose a base branch
from
andig:http-sampling-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
881e095
feat: implement sampling support for Streamable HTTP transport
andig d239784
feat: implement server-side sampling support for HTTP transport
andig dd877e0
fix: replace time.Sleep with synchronization primitives in tests
andig a4ec0b3
fix: improve request detection logic and add nil pointer checks
andig 1cae3a9
fix: correct misleading comment about response delivery
andig 204b273
fix: implement EnableSampling() to properly declare sampling capability
andig 5d4fb64
fix: prevent panic from unsafe type assertion in example server
andig 4e41f25
fix: add missing EnableSampling() call in interface test
andig 178e234
fix: expand error test coverage and avoid t.Fatalf
andig 27322ca
fix: eliminate recursive response handling and improve routing
andig d025975
fix: improve sampling response delivery robustness
andig a9b20be
fix: add graceful shutdown handling to sampling client
andig b7afbb9
fix: improve context handling in streamable HTTP transport
andig a664289
fix: improve error message for notification channel queue full condition
andig bac5dad
refactor: rename struct variable for clarity in message parsing
andig e69716d
test: add concurrent sampling requests test with response association
andig e28a859
fix: improve context handling in async goroutine
andig 4fa5295
refactor: replace interface{} with any throughout codebase
andig 3852e2d
fix: improve context handling in async goroutine for StreamableHTTP
andig 83883ed
refactor: remove unused samplingResponseChan field from session struct
andig 9ea4a10
feat: add graceful shutdown handling to sampling HTTP client example
andig 11f8d0e
refactor: remove unused mu field from streamableHttpSession
andig c1f30be
Merge branch 'main' into http-sampling-improvements
andig 1bda735
Add e2e test
andig 490bcbe
wip
andig e65ac96
wip
andig File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually
from the examples directory. Might be a good idea to make that a global helper function?