Skip to content

Moved _getScroll* to scroll handler, instead of requestAnimFrame. Performance improvement. #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Moved _getScroll* to scroll handler, instead of requestAnimFrame. Performance improvement. #98

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c42b2a1
moved scroll checks from requestAnimFrame to onscroll, improves perfo…
nl5887 Jul 1, 2014
63f8704
moved scroll checks from requestAnimFrame to onscroll, improves perfo…
nl5887 Jul 1, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 33 additions & 29 deletions src/jquery.stellar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,32 +504,25 @@
}
},
_repositionElements: function() {
var scrollLeft = this._getScrollLeft(),
scrollTop = this._getScrollTop(),
horizontalOffset,
verticalOffset,
particle,
fixedRatioOffset,
background,
bgLeft,
bgTop,
isVisibleVertical = true,
isVisibleHorizontal = true,
newPositionLeft,
newPositionTop,
newOffsetLeft,
newOffsetTop,
i;

// First check that the scroll position or container size has changed
if (this.currentScrollLeft === scrollLeft && this.currentScrollTop === scrollTop && this.currentWidth === this.viewportWidth && this.currentHeight === this.viewportHeight) {
return;
} else {
this.currentScrollLeft = scrollLeft;
this.currentScrollTop = scrollTop;
this.currentWidth = this.viewportWidth;
this.currentHeight = this.viewportHeight;
}
var scrollLeft=this.currentScrollLeft,
scrollTop=this.currentScrollTop,
horizontalOffset,
verticalOffset,
particle,
fixedRatioOffset,
background,
bgLeft,
bgTop,
isVisibleVertical = true,
isVisibleHorizontal = true,
newPositionLeft,
newPositionTop,
newOffsetLeft,
newOffsetTop,
i;

this.currentWidth = this.viewportWidth;
this.currentHeight = this.viewportHeight;

// Reposition elements
for (i = this.particles.length - 1; i >= 0; i--) {
Expand Down Expand Up @@ -595,8 +588,19 @@
ticking = false;
};

var requestTick = function() {
if (!ticking) {
var requestTick = function(evt) {
var scrollLeft = self._getScrollLeft();
var scrollTop = self._getScrollTop();

// First check that the scroll position or container size has changed
if (((self.currentScrollLeft === scrollLeft && self.currentWidth === self.viewportWidth) || !self.options.horizontalScrolling) && ((self.currentScrollTop === scrollTop && self.currentHeight === self.viewportHeight) || !self.options.verticalScrolling)) {
return;
}

self.currentScrollLeft = scrollLeft;
self.currentScrollTop = scrollTop;

if (!ticking) {
requestAnimFrame(update);
ticking = true;
}
Expand Down Expand Up @@ -648,4 +652,4 @@

// Expose the plugin class so it can be modified
window.Stellar = Plugin;
}(jQuery, this, document));
}(jQuery, this, document));