Standardize defines and file formatting#3
Open
skypanther wants to merge 1 commit intomarmilicious:masterfrom
Open
Standardize defines and file formatting#3skypanther wants to merge 1 commit intomarmilicious:masterfrom
skypanther wants to merge 1 commit intomarmilicious:masterfrom
Conversation
Updates all the files to use the same #define statements, with matching names. Also updates the setup() function to use a common pattern for the FastLED.addLeds() function call. Also updates the README with more explicit instructions for customizing and using these sample.This should make it easier These changes should make it easier to use these samples. Novices will find a common pattern, which will be easier to follow. Experienced users will be able to more quickly use each of the samples.
Owner
|
@skypanther Wow Tim, I'm humbled by you taking the time to help improve all these. That's a lot of changes! I'm hoping some of those changes were automated!? |
Author
|
Sorry that it's so large! It's mostly white space / indenting changes. My editor did that as I saved my other changes. The key change for each is really just standardizing the #defines and addLeds statements. I've manually tested many of the updated files, though sorry, not all of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes should make it easier to use these samples. Novices will find a common pattern, which will be easier to follow. Experienced users will be able to more quickly use each of the samples.
Thanks for these samples! They are a great help and I refer to them often.