Skip to content

Refactor package references #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2025
Merged

Refactor package references #968

merged 1 commit into from
Jun 16, 2025

Conversation

martincostello
Copy link
Owner

Cherry-pick changes from #876.

Cherry-pick changes from #876.
@Copilot Copilot AI review requested due to automatic review settings June 16, 2025 11:43
@martincostello martincostello added enhancement .NET Pull requests that update .net code labels Jun 16, 2025
@martincostello martincostello enabled auto-merge (rebase) June 16, 2025 11:43
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.72%. Comparing base (20499b9) to head (35eb4cd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #968   +/-   ##
=======================================
  Coverage   44.72%   44.72%           
=======================================
  Files          21       21           
  Lines         322      322           
  Branches       49       49           
=======================================
  Hits          144      144           
  Misses        162      162           
  Partials       16       16           
Flag Coverage Δ
linux 44.72% <ø> (ø)
macos 44.72% <ø> (ø)
windows 44.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors package management by cherry-picking changes from #876 to surface version overrides directly in the Automate project and cleaning up central definitions.

  • Explicitly target netstandard2.0 in the Automate csproj and add a VersionOverride for System.Text.Json
  • Remove System.Net.Http.Json and System.Text.Json from Directory.Packages.props to centralize overrides in individual projects

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/MartinCostello.BrowserStack.Automate/MartinCostello.BrowserStack.Automate.csproj Adjusted ItemGroup conditions and added VersionOverride for System.Text.Json in the netstandard2.0 group
Directory.Packages.props Removed central PackageVersion entries for System.Net.Http.Json and System.Text.Json
Comments suppressed due to low confidence (2)

src/MartinCostello.BrowserStack.Automate/MartinCostello.BrowserStack.Automate.csproj:19

  • After removing central versions for System.Text.Json and System.Net.Http.Json, this net8.0 ItemGroup is missing explicit references for those packages. Add <PackageReference Include="System.Text.Json" VersionOverride="[8.0.5,)" /> and <PackageReference Include="System.Net.Http.Json" VersionOverride="[8.0.0,)" /> to avoid build errors.
<ItemGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">

src/MartinCostello.BrowserStack.Automate/MartinCostello.BrowserStack.Automate.csproj:14

  • [nitpick] Using an explicit equality check limits future TFM variants. If the intent is to include all frameworks incompatible with net8.0, consider reverting to the MSBuild compatibility function or expanding the condition accordingly.
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">

@martincostello martincostello merged commit 0bf8b95 into main Jun 16, 2025
14 checks passed
@martincostello martincostello deleted the refactor-references branch June 16, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant