Always include config.h before util.h - #839
Open
vkareh wants to merge 1 commit into
Open
Conversation
The util.h file guards verbose output through WITH_VERBOSE_MODE, which is defined in config.h. This means that verbose mode would have never worked on some of these files unless config.h was included first. All other files with verbose output calls already include config.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The util.h file guards verbose output through
WITH_VERBOSE_MODE, which is defined in config.h. This means that verbose mode would have never worked on some of these files unless config.h was included first.All other files with verbose output calls already include config.h.