fix(radio): move root assignment to mirror hostDisconnected #5845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression caused by 688ab3c where calling hostConnected / hostDisconnected in rapid succession can cause root to become null.
|
Seems like a simple fix to me, I'll import to run tests. Is there any way to simulate Angular's behavior? Would directly calling the lifecycles in the order you describe be a way to test it? |
asyncliz
requested changes
Sep 2, 2025
|
@asyncliz Here's a Lit Playground that simulates what it'd be like to call the lifecycles manually. |
asyncliz
approved these changes
Sep 4, 2025
copybara-service
bot
merged commit 834a166
into
material-components:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression caused by 688ab3c where calling hostConnected / hostDisconnected in rapid succession can cause root to become null. This regression can be experienced in Angular where content projection causes it to call hostConnected → hostDisconnected → hostConnected in rapid succession. I'm not familiar enough with Angular's internals to know why it needs to do this multiple times in a row but regardless the two lifecycles should be mirrored.