Add tests for downgrading a v12 room to one that doesn't support MSC4289 #794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some tests for downgrading a v12 room. Also cleans up some existing tests and fixes a typo.
additional_creators
) to in the new room when downgrading to a room that does not support MSC4289.The general consensus seems to be setting their power level(s) to the minimum needed to send
m.room.power_levels
in the room - aka being able to do anything you want in the room. Synapse implements this as taking the max of all fields underevents
, andstate_default
(which would apply tom.room.power_levels
if it wasn't listed underevents
).This PR would effectively be requiring the above of homeservers without the spec having yet agreed on it yet. We should hold off on merging this PR until that is decided.
Recommended to review commit-by-commit.