Add support for login_hint in authorization url generation #4943
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
odelcroi
force-pushed
the
feat/allow-login-hint
branch
from
3bda675 to
2b331a6
Compare
Signed-off-by: olivier <[email protected]> Signed-off-by: olivier <[email protected]> fix lint Signed-off-by: olivier <[email protected]>
odelcroi
force-pushed
the
feat/allow-login-hint
branch
from
2b331a6 to
e17dc97
Compare
4 tasks
dbkr
approved these changes
Jul 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
richvdh
requested changes
Jul 29, 2025
| @@ -125,6 +125,7 @@ export const generateAuthorizationUrl = async ( | |||
| * @param prompt - indicates to the OP which flow the user should see - eg login or registration | |||
| * See https://openid.net/specs/openid-connect-prompt-create-1_0.html#name-prompt-parameter | |||
| * @param urlState - value to append to the opaque state identifier to uniquely identify the callback | |||
| * @param loginHint - send connecting user login hint to OP | |||
There was a problem hiding this comment.
I don't really understand this documentation?
There was a problem hiding this comment.
from the spec :
Suggested change
| * @param loginHint - send connecting user login hint to OP | |
| * @param loginHint - hint to the OP about the login identifier the user might use to log in |
There was a problem hiding this comment.
maybe:
Suggested change
| * @param loginHint - send connecting user login hint to OP | |
| * @param loginHint - value to send as the `login_hint` to the OP, giving a hint about the login identifier the user might use to log in. See {@link https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest OIDC core 3.1.2.1}. |
?
mcalinghee
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for using login_hint when connecting with oidc native flow in Element Web
Server side PR in MAS : element-hq/matrix-authentication-service#4568
Checklist
public/exportedsymbols have accurate TSDoc documentation.