Use hydra semantics for unknown room versions #4957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This inverts the check for whether to use hydra semantics to only NOT use it for known, old room versions and use hydra for everything else, so rooms with versions we don't know about will use hydra semantics. This will cause any rooms using old/experiental versions unknown to the js-sdk to break, but will mean that wehn the next room version comes out, we'll use hydra for it which is, of course, not a given, but is way more likely than going back to the old semantics. The mobile Element clients currently hardcode hydra versions (ie. as it is without this change, but we expect them to make this same change soon after the hydra release. We do NOT expect this to land with the hydra release, but target it for the release after. Reverts 1e5054a from #4937 See element-hq/element-meta#2921 for public discussion.
richvdh
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This inverts the check for whether to use hydra semantics to only NOT use it for known, old room versions and use hydra for everything else, so rooms with versions we don't know about will use hydra semantics.
This will cause any rooms using old/experimental versions unknown to the js-sdk to break, but will mean that when the next room version comes out, we'll use hydra for it which is, of course, not a given, but is way more likely than going back to the old semantics.
The mobile Element clients currently hardcode hydra versions (ie. as it is without this change, but we expect them to make this same change soon after the hydra release.
We do NOT expect this to land with the hydra release, but target it for the release after.
Reverts 1e5054a from #4937
See element-hq/element-meta#2921 for public discussion.
Checklist
public/exportedsymbols have accurate TSDoc documentation.