chore(bench): Update Criterion to 0.6 #5408
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5408 +/- ##
=======================================
Coverage 88.80% 88.81%
=======================================
Files 334 334
Lines 91256 91256
Branches 91256 91256
=======================================
+ Hits 81044 81051 +7
+ Misses 6399 6391 -8
- Partials 3813 3814 +1 ☔ View full report in Codecov by Sentry. |
|
Cannot update to Criterion 0.16 because pprof is still using 0.15, https://crates.io/crates/pprof/0.15.0/dependencies. Need to wait on tikv/pprof-rs#274 to be addressed. |
|
This has been superseded by #5443. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does exactly what it says on the tin.