-
Notifications
You must be signed in to change notification settings - Fork 332
Bump the base crate to 2024 edition and use let-chains in there #5431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reverting to draft at the moment; we should first land the Ruma bump, otherwise this will cause some unnecessary rebase pain for the author. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #5431 +/- ##
==========================================
- Coverage 88.86% 88.86% -0.01%
==========================================
Files 333 333
Lines 91374 91402 +28
Branches 91374 91402 +28
==========================================
+ Hits 81199 81223 +24
- Misses 6351 6355 +4
Partials 3824 3824 ☔ View full report in Codecov by Sentry. |
70da12c
to
bcb2589
Compare
bcb2589
to
2254c11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than CI failing due to the no-longer-used OptionExt
trait, and my (very much not important) nit above, LGTM.
2254c11
to
36059b3
Compare
…which requires the base crate to use the 2024 edition.