Skip to content

Conversation

bnjbvr
Copy link
Member

@bnjbvr bnjbvr commented Jul 22, 2025

…which requires the base crate to use the 2024 edition.

@bnjbvr bnjbvr requested a review from a team as a code owner July 22, 2025 09:30
@bnjbvr bnjbvr requested review from poljar and removed request for a team July 22, 2025 09:30
@bnjbvr bnjbvr marked this pull request as draft July 22, 2025 09:41
@bnjbvr bnjbvr removed the request for review from poljar July 22, 2025 09:41
@bnjbvr
Copy link
Member Author

bnjbvr commented Jul 22, 2025

Reverting to draft at the moment; we should first land the Ruma bump, otherwise this will cause some unnecessary rebase pain for the author.

@bnjbvr bnjbvr changed the title Bump the MSRV to 1.88 for let-chains and use them in the base crate Bump the base crate to 2024 edition and use let-chains in there Jul 22, 2025
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 86.89024% with 43 lines in your changes missing coverage. Please review.

Project coverage is 88.86%. Comparing base (bcb4ab4) to head (36059b3).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-base/src/room/room_info.rs 13.88% 22 Missing and 9 partials ⚠️
...base/src/response_processors/e2ee/tracked_users.rs 66.66% 0 Missing and 4 partials ⚠️
crates/matrix-sdk-base/src/store/memory_store.rs 73.33% 0 Missing and 4 partials ⚠️
...tes/matrix-sdk-base/src/store/integration_tests.rs 94.23% 0 Missing and 3 partials ⚠️
crates/matrix-sdk-base/src/latest_event.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5431      +/-   ##
==========================================
- Coverage   88.86%   88.86%   -0.01%     
==========================================
  Files         333      333              
  Lines       91374    91402      +28     
  Branches    91374    91402      +28     
==========================================
+ Hits        81199    81223      +24     
- Misses       6351     6355       +4     
  Partials     3824     3824              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bnjbvr bnjbvr force-pushed the bnjbvr/let-chains branch from 70da12c to bcb2589 Compare July 22, 2025 16:03
@bnjbvr bnjbvr marked this pull request as ready for review July 22, 2025 16:03
@bnjbvr bnjbvr force-pushed the bnjbvr/let-chains branch from bcb2589 to 2254c11 Compare July 22, 2025 16:03
@bnjbvr bnjbvr requested a review from jplatte July 22, 2025 16:04
Copy link
Collaborator

@jplatte jplatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than CI failing due to the no-longer-used OptionExt trait, and my (very much not important) nit above, LGTM.

@bnjbvr bnjbvr force-pushed the bnjbvr/let-chains branch from 2254c11 to 36059b3 Compare July 22, 2025 19:12
@bnjbvr bnjbvr merged commit 2710510 into main Jul 23, 2025
45 checks passed
@bnjbvr bnjbvr deleted the bnjbvr/let-chains branch July 23, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants