Skip to content

Conversation

zecakeh
Copy link
Collaborator

@zecakeh zecakeh commented Jul 22, 2025

Follow-up to #5337.

This is mainly about the added JsonCastable bound on the Raw API.

Split into commits by theme for easier review, however they should be squashed together.

zecakeh added 3 commits July 22, 2025 14:05
Signed-off-by: Kévin Commaille <[email protected]>
@zecakeh zecakeh requested review from a team as code owners July 22, 2025 12:22
@zecakeh zecakeh requested review from bnjbvr and poljar and removed request for a team July 22, 2025 12:22
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 76.74419% with 30 lines in your changes missing coverage. Please review.

Project coverage is 88.86%. Comparing base (37626b5) to head (15f36cf).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
crates/matrix-sdk-base/src/store/memory_store.rs 33.33% 11 Missing and 1 partial ⚠️
crates/matrix-sdk/src/event_handler/mod.rs 20.00% 0 Missing and 4 partials ⚠️
crates/matrix-sdk/src/room/mod.rs 50.00% 2 Missing and 2 partials ⚠️
crates/matrix-sdk-base/src/store/traits.rs 60.00% 0 Missing and 2 partials ⚠️
...es/matrix-sdk-common/src/deserialized_responses.rs 88.88% 1 Missing ⚠️
crates/matrix-sdk-crypto/src/gossiping/machine.rs 0.00% 0 Missing and 1 partial ⚠️
crates/matrix-sdk-crypto/src/machine/mod.rs 50.00% 0 Missing and 1 partial ⚠️
...rates/matrix-sdk-crypto/src/types/one_time_keys.rs 0.00% 0 Missing and 1 partial ⚠️
...-sdk/src/encryption/secret_storage/secret_store.rs 66.66% 0 Missing and 1 partial ⚠️
crates/matrix-sdk/src/event_cache/room/mod.rs 0.00% 0 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5433      +/-   ##
==========================================
+ Coverage   88.85%   88.86%   +0.01%     
==========================================
  Files         333      333              
  Lines       91356    91374      +18     
  Branches    91356    91374      +18     
==========================================
+ Hits        81172    81202      +30     
+ Misses       6360     6348      -12     
  Partials     3824     3824              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kévin Commaille <[email protected]>
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@bnjbvr bnjbvr removed the request for review from poljar July 22, 2025 12:54
@bnjbvr bnjbvr enabled auto-merge (squash) July 22, 2025 12:54
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@poljar poljar disabled auto-merge July 22, 2025 12:55
@poljar poljar enabled auto-merge (squash) July 22, 2025 12:56
@poljar poljar merged commit 4931c07 into matrix-org:main Jul 22, 2025
45 checks passed
@zecakeh zecakeh deleted the bump-ruma-json-castable branch July 22, 2025 13:24
@zecakeh zecakeh mentioned this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants