Skip to content

Conversation

@Johennes
Copy link
Contributor

@Johennes Johennes commented Oct 24, 2025

This adds the flow for reciprocating a login by generating a QR code on the logged in device as per MSC4108. Two required refactoring commits are also included which I hope is ok as they felt too small to justify being put into their own PR. I'm planning to add the complementary flow where the existing device scans the QR code in a separate PR.

  • Public API changes documented in changelogs (optional)

…:reciprocate and make it available outside of tests

Signed-off-by: Johannes Marbach <[email protected]>
@Johennes Johennes force-pushed the johannes/qr-login-3 branch from a00d871 to a960510 Compare October 24, 2025 08:25
…ated on the existing device

Signed-off-by: Johannes Marbach <[email protected]>
@Johennes Johennes force-pushed the johannes/qr-login-3 branch from a960510 to 3190a35 Compare October 24, 2025 08:30
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 24, 2025

CodSpeed Performance Report

Merging #5801 will not alter performance

Comparing Johennes:johannes/qr-login-3 (3190a35) with main (34c5e24)

Summary

✅ 50 untouched

@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 91.14391% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.47%. Comparing base (430304f) to head (3190a35).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...src/authentication/oauth/qrcode/reciprocate/mod.rs 68.60% 18 Missing and 9 partials ⚠️
...authentication/oauth/qrcode/reciprocate/scanned.rs 95.17% 13 Missing and 8 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5801      +/-   ##
==========================================
+ Coverage   88.45%   88.47%   +0.01%     
==========================================
  Files         360      362       +2     
  Lines      100328   100865     +537     
  Branches   100328   100865     +537     
==========================================
+ Hits        88749    89239     +490     
- Misses       7413     7443      +30     
- Partials     4166     4183      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Johennes Johennes marked this pull request as ready for review October 24, 2025 08:50
@Johennes Johennes requested a review from a team as a code owner October 24, 2025 08:50
@Johennes Johennes requested review from andybalaam and removed request for a team October 24, 2025 08:50
@poljar poljar requested review from poljar and removed request for andybalaam October 24, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant