Skip to content

FFI: Remove UniFFI Swift mocks workaround now that we're using 0.31.0. - #6378

Merged
poljar merged 1 commit into
mainfrom
doug/remove-uniffi-workaround
Mar 30, 2026
Merged

poljar merged 1 commit into
mainfrom
doug/remove-uniffi-workaround

Conversation

@pixlwave

@pixlwave pixlwave commented Mar 30, 2026 •

Copy link
Copy Markdown
Member

Following on from #6063, the workaround added in #5826 is no longer necessary as it happens automatically with mozilla/uniffi-rs#2720. This PR removes the workaround.

  • I've documented the public API Changes in the appropriate CHANGELOG.md files.
  • This PR was made with the help of AI.

Signed-off-by:

@pixlwave
pixlwave requested a review from a team as a code owner March 30, 2026 16:13
@pixlwave
pixlwave requested review from poljar and removed request for a team March 30, 2026 16:13
@pixlwave

pixlwave commented Mar 30, 2026 •

Copy link
Copy Markdown
Member Author

From what I can tell, xtask changes don't need/have a changelog entry, but let me know if I'm missing something.

@codecov

codecov Bot commented Mar 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.86%. Comparing base (179f38b) to head (090eb23).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6378   +/-   ##
=======================================
  Coverage   89.85%   89.86%           
=======================================
  Files         376      376           
  Lines      103093   103093           
  Branches   103093   103093           
=======================================
+ Hits        92638    92641    +3     
+ Misses       6878     6877    -1     
+ Partials     3577     3575    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed

codspeed Bot commented Mar 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 50 untouched benchmarks


Comparing doug/remove-uniffi-workaround (090eb23) with main (179f38b)

Open in CodSpeed

@poljar poljar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, less code.

@poljar
poljar merged commit 02c41e2 into main Mar 30, 2026
53 checks passed
@poljar
poljar deleted the doug/remove-uniffi-workaround branch March 30, 2026 19:43
@poljar

poljar commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

From what I can tell, xtask changes don't need/have a changelog entry, but let me know if I'm missing something.

No, you're correct, xtask is an internal tool.

@pixlwave

Copy link
Copy Markdown
Member Author

Neat, less code.

Umm yeah, so about that…

#6388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants