Repository navigation
fix(sdk): Do not update the LatestEventValue if its event ID matches the previous value - #6396
Conversation
Merging this PR will degrade performance by 40.62%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | Restore session [memory store] |
165.7 ms | 279 ms | -40.62% |
Comparing Hywan:fix-issue-6381 (6214dd8) with main (9c28ee7)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6396 +/- ##
==========================================
- Coverage 89.83% 89.82% -0.01%
==========================================
Files 378 378
Lines 104214 104314 +100
Branches 104214 104314 +100
==========================================
+ Hits 93622 93702 +80
- Misses 7000 7016 +16
- Partials 3592 3596 +4 ☔ View full report in Codecov by Sentry. |
LatestEventValue is its event ID matches the previous valueLatestEventValue if its event ID matches the previous value
|
Does this need two reviewers or what's going on? |
|
(have rebased to resolve the conflict) |
poljar
left a comment
There was a problem hiding this comment.
Small tweak to the changelog entry required, looks good otherwise.
…s the previous value. This patch updates the logic to update a `LatestEventValue`. We still can't compare two `LatestEventValue` because the type doesn't implement `PartialEq`. However, we can use the `EventId` in some case. It fixes matrix-org#6381.
This patch updates the logic to update a
LatestEventValue. We still can't compare twoLatestEventValuebecause the type doesn't implementPartialEq. However, we can use theEventIdin some case.It fixes #6381.
CHANGELOG.mdfiles.