Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7244 +/- ##
==========================================
- Coverage 90.43% 90.41% -0.02%
==========================================
Files 416 416
Lines 122930 122930
Branches 122930 122930
==========================================
- Hits 111174 111152 -22
- Misses 7617 7626 +9
- Partials 4139 4152 +13 ☔ View full report in Codecov by Harness. |
bnjbvr
force-pushed
the
public-weak-client
branch
from
October 9, 2026 13:40
621129e to
b21248e
Compare
…round tasks Signed-off-by: Benjamin Bouvier <benjamin@bouvier.cc>
And use it throughout the code base instead of `WeakClient::from_client`, which is more verbose and indirect. Signed-off-by: Benjamin Bouvier <benjamin@bouvier.cc>
Signed-off-by: Benjamin Bouvier <benjamin@bouvier.cc>
bnjbvr
force-pushed
the
public-weak-client
branch
from
October 9, 2026 13:44
b21248e to
72599ce
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
WeakClient(weak reference to aClient) is actually useful for external embedders too, who'd like to have access toClients in long-running background tasks, but that shouldn't maintain theClientalive in this case.First commit makes it public. Second commit mimick's
Arc's API and introducesClient::downgrade(), which creates aWeakClient, and seems less weird / more idiomatic than the previousWeakClient::from_clientmethod.WeakClient::from_clienthave been replaced with AI. I've reviewed those.