Skip to content

Conversation

@MdSaifAliMolla
Copy link
Contributor

✔️ Checklist

  • Check for common mistakes:
    • Wrap plain URLs in <> to linkify them (learn more).
    • Use the right level of headings: The page title will use a level 1 headings, so your headings should use level 2 and below.
    • Use internal links: when linking to another page on https://matrix.org, use the Zola [label](@/target.md) syntax.
  • For blog posts:
    • Verify the date and post ordering on the /blog page, especially for multiple posts on the same day. Prefer UTC format, e.g. 2025-12-01T14:00:00Z for Dec 1st, 2025, 2pm UTC.
    • Set the correct author and category. Browse existing ones at https://matrix.org/author/ and https://matrix.org/category/ to match them.
  • Let us know if you are contributing in a specific role, such as on behalf of an organisation or team, for example.
  • Let us know if your PR is time-sensitive in any way.
  • Mention any issues related to the PR. Use GitHub keywords as appropriate.
  • Your individual commits or pull request is signed off.

Fix #2898

@HarHarLinks HarHarLinks requested a review from a team October 7, 2025 09:59
@HarHarLinks HarHarLinks added the enhancement This would be an improvement to the website. label Oct 7, 2025
@MdSaifAliMolla
Copy link
Contributor Author

@MTRNord can you review it?

@HarHarLinks HarHarLinks force-pushed the Support-start-time-and-custom-noscript-texts-in-Youtube-Embedding branch from a426e71 to ab6146f Compare October 25, 2025 20:19
HarHarLinks

This comment was marked as duplicate.

Copy link
Collaborator

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable :) Thank you. Could you also update the documentation about this in CONTENT.md?

I've done if for this PR, but please check that your editor applies our .editorconfig file when editing this repository; particularly you are missing some newlines at the end. See https://gist.github.com/olivertappin/19a95236d8b69f1c9eadfc799a9ab7fc for more info about newlines at the end of files.

@MdSaifAliMolla MdSaifAliMolla force-pushed the Support-start-time-and-custom-noscript-texts-in-Youtube-Embedding branch 2 times, most recently from 7d4f6bc to 4862cbd Compare October 26, 2025 06:55
@MdSaifAliMolla
Copy link
Contributor Author

This looks reasonable :) Thank you. Could you also update the documentation about this in CONTENT.md?

I've done if for this PR, but please check that your editor applies our .editorconfig file when editing this repository; particularly you are missing some newlines at the end. See https://gist.github.com/olivertappin/19a95236d8b69f1c9eadfc799a9ab7fc for more info about newlines at the end of files.

done

@HarHarLinks HarHarLinks force-pushed the Support-start-time-and-custom-noscript-texts-in-Youtube-Embedding branch from b85d604 to a8860ad Compare October 26, 2025 13:34
Copy link
Collaborator

@HarHarLinks HarHarLinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HarHarLinks HarHarLinks merged commit 5dc958b into matrix-org:main Oct 26, 2025
2 checks passed
@MdSaifAliMolla MdSaifAliMolla deleted the Support-start-time-and-custom-noscript-texts-in-Youtube-Embedding branch October 26, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This would be an improvement to the website.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support start time and custom noscript texts in Youtube Embedding

2 participants