Skip to content

Conversation

lightsprint09
Copy link
Contributor

@lightsprint09 lightsprint09 commented Jan 6, 2017

This trys to reduce the duplication of JSONCodable. It is still work in progress. But I would love to hear a few opinions

  • Adds more small tests. When one tests fails it will be clear what causes the error.
  • Reuses more code, which could make maintaining more easy.

lightsprint09 and others added 9 commits November 15, 2016 15:16
# Conflicts:
#	JSONCodable.xcodeproj/xcshareddata/xcschemes/JSONCodable OSX.xcscheme
#	JSONCodable/JSONDecodable.swift
…into refactor-to-remove-duplication

# Conflicts:
#	JSONCodable.xcodeproj/project.pbxproj
#	JSONCodable/JSONEncodable.swift
#	JSONCodable/JSONHelpers.swift
#	JSONCodableTests/RegularTests.swift
@Nadohs
Copy link
Collaborator

Nadohs commented Jan 15, 2017

If you can get rid of duplication within the decode methods and get the tests working that would be great! Currently we are using multiple functions as a work around for the different ways the generic type could be returned, but if you can reuse some of the duplication that could be a nice refactoring win.

More tests are always great too 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants