Skip to content

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 25, 2025

No description provided.

@estelle estelle requested review from a team as code owners June 25, 2025 08:42
@estelle estelle requested review from Josh-Cena, hamishwillee and sideshowbarker and removed request for a team June 25, 2025 08:42
@github-actions github-actions bot added Content:WebAPI Web API docs Content:JS JavaScript docs Content:Learn Learning area docs Content:HTTP HTTP docs Content:Meta Content in the meta docs size/m [PR only] 51-500 LoC changed labels Jun 25, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

mdn-linter

[mdn-linter] reported by reviewdog 🐶


[mdn-linter] reported by reviewdog 🐶


[mdn-linter] reported by reviewdog 🐶


[mdn-linter] reported by reviewdog 🐶


[mdn-linter] reported by reviewdog 🐶


[mdn-linter] reported by reviewdog 🐶


[mdn-linter] reported by reviewdog 🐶

Copy link
Contributor

github-actions bot commented Jun 25, 2025

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. You would need to reinstall your dependencies based on the latest main, because looks like your Prettier is formatting the lists wrong

I did this on a plane with no wifi. I think it's updated correctly when i have a connection.

  1. I strongly suggest you stick with names already in proper-names.txt, or otherwise ensure that they aren't reported by yarn lint:typos.

I'll look into this.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
estelle and others added 7 commits June 26, 2025 10:02
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sideshowbarker sideshowbarker removed their request for review June 27, 2025 08:12
@sideshowbarker sideshowbarker removed the request for review from a team June 27, 2025 08:12
# Create a book
test_author = Author.objects.create(first_name='John', last_name='Smith')
test_author = Author.objects.create(first_name='Dominique', last_name='Rousseau')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estelle Very happy with this but the corresponding changes need to be made to https://github.com/mdn/django-locallibrary-tutorial or this will be destroyed next time I update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@estelle estelle merged commit cf41a29 into main Jul 1, 2025
12 checks passed
@estelle estelle deleted the diversify branch July 1, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs Content:JS JavaScript docs Content:Learn Learning area docs Content:Meta Content in the meta docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants