-
Notifications
You must be signed in to change notification settings - Fork 22.9k
Diversify names in examples #40072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diversify names in examples #40072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You would need to reinstall your dependencies based on the latest main, because looks like your Prettier is formatting the lists wrong
I did this on a plane with no wifi. I think it's updated correctly when i have a connection.
- I strongly suggest you stick with names already in
proper-names.txt
, or otherwise ensure that they aren't reported byyarn lint:typos
.
I'll look into this.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
files/en-us/web/api/publickeycredentialcreationoptions/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredentialcreationoptions/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredentialcreationoptions/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredentialcreationoptions/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredentialcreationoptions/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredentialcreationoptions/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/publickeycredentialcreationoptions/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
# Create a book | ||
test_author = Author.objects.create(first_name='John', last_name='Smith') | ||
test_author = Author.objects.create(first_name='Dominique', last_name='Rousseau') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estelle Very happy with this but the corresponding changes need to be made to https://github.com/mdn/django-locallibrary-tutorial or this will be destroyed next time I update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.