Skip to content

Conversation

Erzender
Copy link
Contributor

Description

Updating a variable name from "someTargetElement" to "someElement" in a given code example

Motivation

The previous name did not seem to match the one that is used in the very same example

Additional details

Related issues and pull requests

@Erzender Erzender requested a review from a team as a code owner July 16, 2025 22:15
@Erzender Erzender requested review from wbamberg and removed request for a team July 16, 2025 22:15
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed labels Jul 16, 2025
Copy link
Contributor

github-actions bot commented Jul 24, 2025

Preview URLs

(comment last updated: 2025-08-01 15:25:26)

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Appreciate you sending a PR.

Would you mind also updating the variable in line 26:
console.log(target.innerHTML); // abc def

@wbamberg wbamberg removed their request for review July 31, 2025 16:36
@github-actions github-actions bot added size/s [PR only] 6-50 LoC changed and removed size/xs [PR only] 0-5 LoC changed labels Aug 1, 2025
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Erzender for your contribution!

Merging this now.

@dipikabh dipikabh merged commit a02fb4e into mdn:main Aug 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants