Bug-1679997 CSS Origin to contentScripts APIs (update) #41025
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies @Rob--W as the other PR was approved, I didn't go looking for additional feedback before merging. |
|
Preview URLs
External URLs (1)URL:
(comment last updated: 2025-09-07 16:36:56) |
Rob--W
reviewed
Sep 4, 2025
| - : An array of objects. Each object has either a property named `file`, which is a URL starting at the extension's manifest.json and pointing to a CSS file to register, or a property named `code`, which is some CSS code to register. | ||
| - `cssOrigin` {{optional_inline}} | ||
| - : `string`. The origin of the CSS to inject. This affects the cascading order (priority) of the injected stylesheets. Takes the values `"author"` and `"user"`. Defaults to `"author"`. | ||
| - : `string`. The style origin for the injection, either `"user"`, to add the CSS as a user stylesheet, or `"author"`, to add it as an author stylesheet. Defaults to ``"author"`. This property is case insensitive in Firefox and Safari. |
There was a problem hiding this comment.
Case insensitivity is only in Firefox 144 and later.
Safari does not support the contentScripts API. The scripting API is the cross-browser version of it.
| - : `array` of `string`. The list of CSS files to be injected into matching pages. These are injected in the order they appear in this array. | ||
| - `cssOrigin` {{optional_inline}} | ||
| - : `string`. The origin of the CSS to inject. This affects the cascading order (priority) of the injected stylesheets. Takes the values `"author"` and `"user"`. Defaults to `"author"`. | ||
| - : `string`. The style origin for the injection, either `"user"`, to add the CSS as a user stylesheet, or `"author"`, to add it as an author stylesheet. Defaults to ``"author"`. This property is case insensitive in Firefox and Safari. |
There was a problem hiding this comment.
Case insensitive in Firefox 144 and later.
github-actions
bot
added
Content:Firefox
|
@Rob--W this should fix the issues, sorry about that. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| </ul> | ||
| <li><code>"user"</code>, to add as a user stylesheet.</li> | ||
| <li><code>"author"</code>, to add as an author stylesheet.</li> | ||
| </ul> |
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| </ul> | |
| </ul> |
Rob--W
reviewed
Sep 6, 2025
Co-authored-by: Rob Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses feedback provided by @Rob--W in #40955 (review)