Skip to content

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Sep 8, 2025

Description

Sets FRED_PLAYGROUND_LOCAL=true on the yarn start script.

Motivation

Ensures that live samples render correctly.

Additional details

Related issues and pull requests

Fixes mdn/fred#701.

@caugner caugner requested a review from mdn-bot as a code owner September 8, 2025 15:03
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/xs [PR only] 0-5 LoC changed labels Sep 8, 2025
@caugner caugner requested a review from LeoMcA September 8, 2025 15:05
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff, tested locally, perhaps we also want to set FRED_PLAYGROUND_PORT=5043 so the ports are next to each other

@caugner
Copy link
Contributor Author

caugner commented Sep 9, 2025

perhaps we also want to set FRED_PLAYGROUND_PORT=5043 so the ports are next to each other

Can't we just default the Playground port to FRED_PORT + 1?

@caugner caugner merged commit ff68fa7 into main Sep 10, 2025
18 checks passed
@caugner caugner deleted the fred-701-use-local-fred-playground branch September 10, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xs [PR only] 0-5 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live sample embed is not rendering when running content locally
2 participants