-
Notifications
You must be signed in to change notification settings - Fork 31
implement rankingScoreThreshold search query parameter #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe changes introduce support for a new optional Changes
Sequence Diagram(s)sequenceDiagram
participant Test as Test Case
participant Client as Search Client
participant Query as SearchQuery
participant Server as Meilisearch Server
Test->>Client: Initiate search with SearchQuery (rankingScoreThreshold=0.9)
Client->>Query: Build query map (includes rankingScoreThreshold)
Client->>Server: Send search request with parameters
Server-->>Client: Return filtered results (rankingScore >= 0.9)
Client-->>Test: Return search results
Test->>Test: Assert all hits have rankingScore >= 0.9
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (3)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 75.19% 76.22% +1.03%
==========================================
Files 60 58 -2
Lines 1524 1506 -18
==========================================
+ Hits 1146 1148 +2
+ Misses 378 358 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b1bf345
to
b3113f7
Compare
Pull Request
Related issue
Fixes #386
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit