feat(targets): Added a new prepare_table_columns method to the SQLConnector base class
#2354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
CodSpeed Performance ReportMerging #2354 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2354 +/- ##
==========================================
- Coverage 90.81% 90.65% -0.17%
==========================================
Files 62 62
Lines 5130 5135 +5
Branches 660 661 +1
==========================================
- Hits 4659 4655 -4
- Misses 330 336 +6
- Partials 141 144 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
edgarrmondragon
changed the title
prepare_table_columns method to the SQLConnector base class
singer_sdk/connectors/sql.py
Outdated
| full_table_name=full_table_name, | ||
| ) | ||
| for property_name, property_def in schema["properties"].items(): | ||
| self.prepare_column( |
Collaborator
There was a problem hiding this comment.
Should we add a deprecation warning when this function is called?
| schema=schema, | ||
| ) | ||
|
|
||
| def prepare_table_columns( |
Collaborator
There was a problem hiding this comment.
I think we should tests for this. tests/core/test_connector_sql.py might a good place for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2353
📚 Documentation preview 📚: https://meltano-sdk--2354.org.readthedocs.build/en/2354/