Skip to content

bug fix for async _add_to_vector_store method #3201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bug fix for async _add_to_vector_store method #3201

wants to merge 1 commit into from
+2 −0

Conversation

skunkwerk
Copy link

@skunkwerk skunkwerk commented Jul 21, 2025 •
edited
Loading

Description

Adds a default value for new_memories_with_actions when the variable new_retrieved_facts is None.

Fixes # 3200

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

The test script in the issue no longer returns an error when I install from my branch.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in memory processing loop (async): cannot access local variable 'new_memories_with_actions' where it is not associated with a value
2 participants
@skunkwerk @CLAassistant