Add handle EoS and SoS options to debug elements #993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelonEkonom
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling start of stream (SoS) and end of stream (EoS) events in debug elements by introducing new callback options.
- Adds
handle_start_of_streamandhandle_end_of_streamoptions to both debug sink and filter elements - Implements the corresponding callback handlers that invoke user-defined functions when these stream events occur
- Fixes existing spelling errors in variable names (
_ingored→_ignored)
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| mix.exs | Version bump from 1.2.3 to 1.2.4 |
| lib/membrane/debug/sink.ex | Adds SoS/EoS handler options and implements corresponding callbacks |
| lib/membrane/debug/filter.ex | Adds SoS/EoS handler options, implements callbacks, and fixes spelling errors |
| CHANGELOG.md | Documents the new feature in version 1.2.4 |
mat-hek
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.