[WC-3051]: Improve file extension validation in file uploader web widget #1802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0b1n
force-pushed
the
fix/file-uploader-extension-check
branch
from
a84d810 to
463e658
Compare
gjulivan
previously approved these changes
Jul 31, 2025
gjulivan
force-pushed
the
fix/file-uploader-extension-check
branch
from
463e658 to
4f1befd
Compare
gjulivan
previously approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
In extension, allow everything except reserved characters that are not allowed in filenames. Also improve error message to better clarify format and examples.
What should be covered while testing?
Test allowing and uploading files with extensions containing special characters (e.g., .tar-gz, .js-map, .c++).