Leaflet bug - Mapbox tiles did not load in certain scenarios #1814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade leaflet from ^1.9.4 to 2.0.0-alpha to fix issues with map tiles not loading - Add getDimensions utility to handle widget dimensions locally - Fix auto-zoom timing in LeafletMap component with proper delay mechanism - Add maxZoom limit (15) to prevent over-zooming when markers are close together - Use pixel-based padding for consistent spacing around markers - Update imports to use local getDimensions utility instead of external dependency - Ensure consistent auto-zoom behavior for Mapbox, OpenStreet, and Here Maps providers Fixes auto-zoom firing too early before markers are properly rendered.
…0.0-alpha - Add Jest setup file with ResizeObserver polyfill to fix test compatibility - Update Jest configuration to use the new setup file - Update all LeafletMap test snapshots to match new Leaflet 2.0.0-alpha structure - Ensure all tests pass with the new Leaflet version dependency
- Change imports back to @mendix/widget-plugin-platform/utils/get-dimensions - Remove local duplicate get-dimensions.ts utility file - Fix module resolution by building widget-plugin-platform package - Maintain all functionality while using shared utility instead of local copy
|
adding internal conversations link for reference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Description
This PR addresses critical issues with the Maps widget's Leaflet-based providers (Mapbox, OpenStreet, and Here Maps) where auto-zoom functionality was firing too early before markers were rendered, and map tiles were not loading properly.
Root cause: The older Leaflet version had compatibility issues with certain tile providers. Additionally, the auto-zoom logic was calculating bounds and setting zoom levels before map markers were fully rendered, resulting in incorrect zoom positioning.
Changes made:
Technical improvements:
Quality assurance:
✅ All 15 tests pass
✅ ESLint validation passes
✅ No breaking changes to existing APIs
✅ Google Maps functionality unchanged
✅ Backward compatibility maintained
What should be covered while testing?
Test scenarios:
Mapbox provider: Verify tiles load correctly and auto-zoom works with proper timing
OpenStreet provider: Test auto-zoom behavior with multiple markers at varying distances
Here Maps provider: Ensure consistent zoom levels and tile loading
Edge cases: Test with markers very close together (should respect maxZoom: 15 limit)
Performance: Verify the 100ms delay doesn't negatively impact user experience
Expected behavior:
Map tiles should load immediately without blank/missing areas
Auto-zoom should trigger after markers are visible and position the map correctly
Zoom level should be reasonable even when markers are clustered closely
No regression in manual zoom or other existing functionality
Checklist review:
❌ JIRA story: No JIRA ticket
❌ Version bump: Maybe not required - bug fix maintains API compatibility
❌ Related PRs: None in other repositories
❌ Documentation: No XML changes or new features requiring docs
✅ Bug fix: Detailed testing instructions provided above