[pull] master from serde-rs:master #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Resolve manual_hash_one lint in test
Restore doc cfg on re-exports
Set limb width to 64 for loongarch64
rust-lang/rust-clippy#12133 warning: function cannot return without recursing --> src/map.rs:276:5 | 276 | / fn eq(&self, other: &Self) -> bool { 277 | | self.map.eq(&other.map) 278 | | } | |_____^ | note: recursive call site --> src/map.rs:277:9 | 277 | self.map.eq(&other.map) | ^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unconditional_recursion = note: `-W clippy::unconditional-recursion` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::unconditional_recursion)]`
Fixed a spelling error in the second paragraph of the README file. - Changed "exponet" to "exponent"
fix: Correct spelling error
Handle Unexpected::Unit in Error::invalid_value
Format f64 in error messages using ryu
Add swap_remove and shift_remove methods on Map
warning: method `is_sign_negative` is never used
--> src/lexical/num.rs:251:8
|
175 | pub trait Float: Number {
| ----- method in this trait
...
251 | fn is_sign_negative(self) -> bool;
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
rust-lang/rust-clippy#12257 warning: current MSRV (Minimum Supported Rust Version) is `1.56.0` but this item is stable since `1.71.0` --> tests/test.rs:2500:25 | 2500 | assert_ne!(rand.hash_one(k1), rand.hash_one(k2)); | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv = note: `-W clippy::incompatible-msrv` implied by `-W clippy::all` = help: to override `-W clippy::all` add `#[allow(clippy::incompatible_msrv)]` warning: current MSRV (Minimum Supported Rust Version) is `1.56.0` but this item is stable since `1.71.0` --> tests/test.rs:2500:44 | 2500 | assert_ne!(rand.hash_one(k1), rand.hash_one(k2)); | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv warning: current MSRV (Minimum Supported Rust Version) is `1.56.0` but this item is stable since `1.71.0` --> tests/test.rs:2503:25 | 2503 | assert_eq!(rand.hash_one(k1), rand.hash_one(k2)); | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv warning: current MSRV (Minimum Supported Rust Version) is `1.56.0` but this item is stable since `1.71.0` --> tests/test.rs:2503:44 | 2503 | assert_eq!(rand.hash_one(k1), rand.hash_one(k2)); | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
rust-lang/rust#117772 warning: the item `String` is imported redundantly --> src/de.rs:8:5 | 8 | use alloc::string::String; | ^^^^^^^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `String` is already defined here | = note: `#[warn(unused_imports)]` on by default warning: the item `Vec` is imported redundantly --> src/de.rs:9:5 | 9 | use alloc::vec::Vec; | ^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `Vec` is already defined here warning: the item `Box` is imported redundantly --> src/error.rs:4:5 | 4 | use alloc::boxed::Box; | ^^^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `Box` is already defined here warning: the item `String` is imported redundantly --> src/error.rs:5:21 | 5 | use alloc::string::{String, ToString}; | ^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `String` is already defined here warning: the item `ToString` is imported redundantly --> src/error.rs:5:29 | 5 | use alloc::string::{String, ToString}; | ^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `ToString` is already defined here warning: the item `String` is imported redundantly --> src/map.rs:10:5 | 10 | use alloc::string::String; | ^^^^^^^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `String` is already defined here warning: the item `indexmap` is imported redundantly --> src/map.rs:23:16 | 23 | use indexmap::{self, IndexMap}; | ^^^^ the item `indexmap` is already defined here | = note: `#[warn(unused_imports)]` on by default warning: the item `String` is imported redundantly --> src/ser.rs:5:21 | 5 | use alloc::string::{String, ToString}; | ^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `String` is already defined here warning: the item `ToString` is imported redundantly --> src/ser.rs:5:29 | 5 | use alloc::string::{String, ToString}; | ^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `ToString` is already defined here warning: the item `Vec` is imported redundantly --> src/ser.rs:6:5 | 6 | use alloc::vec::Vec; | ^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `Vec` is already defined here warning: the item `String` is imported redundantly --> src/value/mod.rs:95:5 | 95 | use alloc::string::String; | ^^^^^^^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `String` is already defined here warning: the item `Vec` is imported redundantly --> src/value/mod.rs:96:5 | 96 | use alloc::vec::Vec; | ^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `Vec` is already defined here warning: the item `ToOwned` is imported redundantly --> src/value/de.rs:5:26 | 5 | use alloc::borrow::{Cow, ToOwned}; | ^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `ToOwned` is already defined here warning: the item `String` is imported redundantly --> src/value/de.rs:6:5 | 6 | use alloc::string::String; | ^^^^^^^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `String` is already defined here warning: the item `Vec` is imported redundantly --> src/value/de.rs:9:24 | 9 | use alloc::vec::{self, Vec}; | ^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `Vec` is already defined here warning: the item `String` is imported redundantly --> src/value/from.rs:5:21 | 5 | use alloc::string::{String, ToString}; | ^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `String` is already defined here warning: the item `ToString` is imported redundantly --> src/value/from.rs:5:29 | 5 | use alloc::string::{String, ToString}; | ^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `ToString` is already defined here warning: the item `Vec` is imported redundantly --> src/value/from.rs:6:5 | 6 | use alloc::vec::Vec; | ^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `Vec` is already defined here warning: the item `ToOwned` is imported redundantly --> src/value/index.rs:3:5 | 3 | use alloc::borrow::ToOwned; | ^^^^^^^^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `ToOwned` is already defined here warning: the item `String` is imported redundantly --> src/value/index.rs:4:5 | 4 | use alloc::string::String; | ^^^^^^^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `String` is already defined here warning: the item `String` is imported redundantly --> src/value/partial_eq.rs:2:5 | 2 | use alloc::string::String; | ^^^^^^^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `String` is already defined here warning: the item `ToOwned` is imported redundantly --> src/value/ser.rs:4:5 | 4 | use alloc::borrow::ToOwned; | ^^^^^^^^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `ToOwned` is already defined here warning: the item `String` is imported redundantly --> src/value/ser.rs:5:21 | 5 | use alloc::string::{String, ToString}; | ^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `String` is already defined here warning: the item `ToString` is imported redundantly --> src/value/ser.rs:5:29 | 5 | use alloc::string::{String, ToString}; | ^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `ToString` is already defined here warning: the item `Vec` is imported redundantly --> src/value/ser.rs:6:5 | 6 | use alloc::vec::Vec; | ^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `Vec` is already defined here warning: the item `Vec` is imported redundantly --> src/read.rs:2:5 | 2 | use alloc::vec::Vec; | ^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `Vec` is already defined here warning: the item `ToString` is imported redundantly --> tests/test.rs:46:5 | 46 | use std::string::ToString; | ^^^^^^^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `ToString` is already defined here | = note: `#[warn(unused_imports)]` on by default warning: the item `Vec` is imported redundantly --> tests/../src/lexical/bignum.rs:6:5 | 6 | use alloc::vec::Vec; | ^^^^^^^^^^^^^^^ | ::: nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/prelude/mod.rs:125:13 | 125 | pub use super::v1::*; | --------- the item `Vec` is already defined here | = note: `#[warn(unused_imports)]` on by default
warning: the following explicit lifetimes could be elided: 'a
--> src/de.rs:2189:11
|
2189 | impl<'de, 'a, R> MapKey<'a, R>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
= note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]`
help: elide the lifetimes
|
2189 - impl<'de, 'a, R> MapKey<'a, R>
2189 + impl<'de, R> MapKey<'_, R>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/de.rs:2196:11
|
2196 | impl<'de, 'a, R> de::Deserializer<'de> for MapKey<'a, R>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
2196 - impl<'de, 'a, R> de::Deserializer<'de> for MapKey<'a, R>
2196 + impl<'de, R> de::Deserializer<'de> for MapKey<'_, R>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/error.rs:467:6
|
467 | impl<'a> Display for JsonUnexpected<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
467 - impl<'a> Display for JsonUnexpected<'a> {
467 + impl Display for JsonUnexpected<'_> {
|
warning: the following explicit lifetimes could be elided: 'de
--> src/map.rs:601:6
|
601 | impl<'de> de::IntoDeserializer<'de, Error> for Map<String, Value> {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
601 - impl<'de> de::IntoDeserializer<'de, Error> for Map<String, Value> {
601 + impl de::IntoDeserializer<'_, Error> for Map<String, Value> {
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:31:6
|
31 | impl<'a, W> Serializer<W, PrettyFormatter<'a>>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
31 - impl<'a, W> Serializer<W, PrettyFormatter<'a>>
31 + impl<W> Serializer<W, PrettyFormatter<'_>>
|
warning: the following explicit lifetimes could be elided: 'ser
--> src/ser.rs:420:14
|
420 | impl<'ser, W, F> Write for Adapter<'ser, W, F>
| ^^^^ ^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
420 - impl<'ser, W, F> Write for Adapter<'ser, W, F>
420 + impl<W, F> Write for Adapter<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:480:6
|
480 | impl<'a, W, F> ser::SerializeSeq for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
480 - impl<'a, W, F> ser::SerializeSeq for Compound<'a, W, F>
480 + impl<W, F> ser::SerializeSeq for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:527:6
|
527 | impl<'a, W, F> ser::SerializeTuple for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
527 - impl<'a, W, F> ser::SerializeTuple for Compound<'a, W, F>
527 + impl<W, F> ser::SerializeTuple for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:549:6
|
549 | impl<'a, W, F> ser::SerializeTupleStruct for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
549 - impl<'a, W, F> ser::SerializeTupleStruct for Compound<'a, W, F>
549 + impl<W, F> ser::SerializeTupleStruct for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:571:6
|
571 | impl<'a, W, F> ser::SerializeTupleVariant for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
571 - impl<'a, W, F> ser::SerializeTupleVariant for Compound<'a, W, F>
571 + impl<W, F> ser::SerializeTupleVariant for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:609:6
|
609 | impl<'a, W, F> ser::SerializeMap for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
609 - impl<'a, W, F> ser::SerializeMap for Compound<'a, W, F>
609 + impl<W, F> ser::SerializeMap for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:681:6
|
681 | impl<'a, W, F> ser::SerializeStruct for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
681 - impl<'a, W, F> ser::SerializeStruct for Compound<'a, W, F>
681 + impl<W, F> ser::SerializeStruct for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:727:6
|
727 | impl<'a, W, F> ser::SerializeStructVariant for Compound<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
727 - impl<'a, W, F> ser::SerializeStructVariant for Compound<'a, W, F>
727 + impl<W, F> ser::SerializeStructVariant for Compound<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:793:6
|
793 | impl<'a, W, F> ser::Serializer for MapKeySerializer<'a, W, F>
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
793 - impl<'a, W, F> ser::Serializer for MapKeySerializer<'a, W, F>
793 + impl<W, F> ser::Serializer for MapKeySerializer<'_, W, F>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:1979:6
|
1979 | impl<'a> Default for PrettyFormatter<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
1979 - impl<'a> Default for PrettyFormatter<'a> {
1979 + impl Default for PrettyFormatter<'_> {
|
warning: the following explicit lifetimes could be elided: 'a
--> src/ser.rs:1985:6
|
1985 | impl<'a> Formatter for PrettyFormatter<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
1985 - impl<'a> Formatter for PrettyFormatter<'a> {
1985 + impl Formatter for PrettyFormatter<'_> {
|
warning: the following explicit lifetimes could be elided: 'a, 'b
--> src/value/mod.rs:227:14
|
227 | impl<'a, 'b> io::Write for WriterFormatter<'a, 'b> {
| ^^ ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
227 - impl<'a, 'b> io::Write for WriterFormatter<'a, 'b> {
227 + impl io::Write for WriterFormatter<'_, '_> {
|
warning: the following explicit lifetimes could be elided: 'de
--> src/value/de.rs:526:6
|
526 | impl<'de> IntoDeserializer<'de, Error> for Value {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
526 - impl<'de> IntoDeserializer<'de, Error> for Value {
526 + impl IntoDeserializer<'_, Error> for Value {
|
warning: the following explicit lifetimes could be elided: 'de
--> src/value/de.rs:1343:6
|
1343 | impl<'de> Visitor<'de> for KeyClassifier {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
1343 - impl<'de> Visitor<'de> for KeyClassifier {
1343 + impl Visitor<'_> for KeyClassifier {
|
warning: the following explicit lifetimes could be elided: 'a
--> src/value/index.rs:146:6
|
146 | impl<'a> Display for Type<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
146 - impl<'a> Display for Type<'a> {
146 + impl Display for Type<'_> {
|
warning: the following explicit lifetimes could be elided: 'de
--> src/number.rs:403:14
|
403 | impl<'de> Visitor<'de> for NumberVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
403 - impl<'de> Visitor<'de> for NumberVisitor {
403 + impl Visitor<'_> for NumberVisitor {
|
warning: the following explicit lifetimes could be elided: 'b, 'c
--> src/read.rs:132:6
|
132 | impl<'b, 'c, T> Deref for Reference<'b, 'c, T>
| ^^ ^^ ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
132 - impl<'b, 'c, T> Deref for Reference<'b, 'c, T>
132 + impl<T> Deref for Reference<'_, '_, T>
|
warning: the following explicit lifetimes could be elided: 'a
--> src/read.rs:541:6
|
541 | impl<'a> private::Sealed for SliceRead<'a> {}
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
541 - impl<'a> private::Sealed for SliceRead<'a> {}
541 + impl private::Sealed for SliceRead<'_> {}
|
warning: the following explicit lifetimes could be elided: 'a
--> src/read.rs:679:6
|
679 | impl<'a> private::Sealed for StrRead<'a> {}
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
679 - impl<'a> private::Sealed for StrRead<'a> {}
679 + impl private::Sealed for StrRead<'_> {}
|
warning: the following explicit lifetimes could be elided: 'a
--> src/read.rs:833:6
|
833 | impl<'a> Fused for SliceRead<'a> {}
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
833 - impl<'a> Fused for SliceRead<'a> {}
833 + impl Fused for SliceRead<'_> {}
|
warning: the following explicit lifetimes could be elided: 'a
--> src/read.rs:834:6
|
834 | impl<'a> Fused for StrRead<'a> {}
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
help: elide the lifetimes
|
834 - impl<'a> Fused for StrRead<'a> {}
834 + impl Fused for StrRead<'_> {}
|
warning: the following explicit lifetimes could be elided: 'de
--> tests/regression/issue845.rs:12:6
|
12 | impl<'de, T> serde::de::Visitor<'de> for NumberVisitor<T>
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#elidable_lifetime_names
= note: `-W clippy::elidable-lifetime-names` implied by `-W clippy::pedantic`
= help: to override `-W clippy::pedantic` add `#[allow(clippy::elidable_lifetime_names)]`
help: elide the lifetimes
|
12 - impl<'de, T> serde::de::Visitor<'de> for NumberVisitor<T>
12 + impl<T> serde::de::Visitor<'_> for NumberVisitor<T>
|
warning: calling .bytes() is very inefficient when data is not in memory
--> src/read.rs:202:40
|
202 | iter: LineColIterator::new(reader.bytes()),
| ^^^^^^^^^^^^^^
|
= help: consider using `BufReader`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes
= note: `-W clippy::unbuffered-bytes` implied by `-W clippy::all`
= help: to override `-W clippy::all` add `#[allow(clippy::unbuffered_bytes)]`
Delete unused gcc installation
Signed-off-by: jimmycathy <[email protected]>
chore: fix typo
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/map.rs:274:21
|
274 | pub fn entry<S>(&mut self, key: S) -> Entry
| ^^^^^^^^^ ----- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
= note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
274 | pub fn entry<S>(&mut self, key: S) -> Entry<'_>
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/map.rs:303:17
|
303 | pub fn iter(&self) -> Iter {
| ^^^^^ ---- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
303 | pub fn iter(&self) -> Iter<'_> {
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/map.rs:311:21
|
311 | pub fn iter_mut(&mut self) -> IterMut {
| ^^^^^^^^^ ------- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
311 | pub fn iter_mut(&mut self) -> IterMut<'_> {
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/map.rs:319:17
|
319 | pub fn keys(&self) -> Keys {
| ^^^^^ ---- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
319 | pub fn keys(&self) -> Keys<'_> {
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/map.rs:327:19
|
327 | pub fn values(&self) -> Values {
| ^^^^^ ------ the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
327 | pub fn values(&self) -> Values<'_> {
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/map.rs:335:23
|
335 | pub fn values_mut(&mut self) -> ValuesMut {
| ^^^^^^^^^ --------- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
335 | pub fn values_mut(&mut self) -> ValuesMut<'_> {
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/value/de.rs:1388:19
|
1388 | fn unexpected(&self) -> Unexpected {
| ^^^^^ ---------- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
1388 | fn unexpected(&self) -> Unexpected<'_> {
| ++++
warning: lifetime flowing from input to output with different syntax can be confusing
--> src/number.rs:798:30
|
798 | pub(crate) fn unexpected(&self) -> Unexpected {
| ^^^^^ ---------- the lifetime gets resolved as `'_`
| |
| this lifetime flows to the output
|
help: one option is to remove the lifetime for references and use the anonymous lifetime for paths
|
798 | pub(crate) fn unexpected(&self) -> Unexpected<'_> {
| ++++
…ndtrip EscapeChar to the u8 without actually branching
string serialization escaping optimisations
feat: impl Default for &Value
This reverts commit c1826eb.
Implement Default for CompactFormatter
Add Clone and Debug impls to map iterators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )