-
Notifications
You must be signed in to change notification settings - Fork 29
Sync modem presets with current firmware #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Replace array-based modem configuration with preset dictionary - Add missing SHORT_TURBO preset (500kHz, SF=7, CR=5) - Fix coding rates to match firmware (CR=5 for most, CR=8 for LONG_MODERATE/SLOW) - Add current_preset property for cleaner access throughout codebase - Update all references from array indices to string-based preset names - Add Docker support for testing without local environment setup This brings the simulator in sync with the current Meshtastic firmware modem presets and improves maintainability with string-based configuration.
It looks like the coding rate (CR) was wrong for some of the configs. Modem Preset Configuration Differences
|
Looking good @powersjcb, thanks.
True, actually we changed this somewhere in firmware 2.4 I think. It's a non-breaking change as the CR is in the LoRa header, so you can change it on the fly even. |
Hey @powersjcb, hope you had a good time at Burning Man. If you have time, could you separate the optimizations from the Burning Man-specific changes so we could get this merged? |
This brings the simulator in sync with the current Meshtastic firmware modem presets and improves maintainability with string-based configuration.