dependencies: support custom stdatomic lookup for MSVC #15362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mochaaP
commented
Dec 9, 2025
| self.is_found = True | ||
| elif self.clib_compiler.get_id() == 'msvc': | ||
| feature_flag = '/experimental:c11atomics' | ||
| std_args = self.clib_compiler.get_option_std_args(None, None) |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if this call is acceptable in dependency lookup.
<vcruntime_c11_stdatomic.h> rejects __STDC_VERSION__ < 201112L, and MSVC defaults to C99
Contributor
Author
There was a problem hiding this comment.
If we don't care about the symbol being available, just test for compiler version >=19.35.32124 + the header being there, and always provide /experimental:c11atomics
mochaaP
force-pushed
the
mochaa/msvc-stdatomic
branch
from
b262c0e to
ccca7fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #14233
Fixes: f070670