Ensure detailed machine info for ASM compilers #15366
Open
+29
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
force-pushed
the
submit/detect-machine-info-for-asm
branch
from
6dd64eb to
b25e5f0
Compare
Instead of having it in the interpreter. We're going to need to update this inside of the compiler detection in the next patch.
The ASM compilers need the machine information to be up to date before they're initialized. Which is a reasonable thing as they use the c linker information. This was done by creating a unique MachineInfo. That code was dropped when the compilers were refactored to use the Environment instead of a separate MachineInfo. This patch is honestly not what I'd hope for, but it's minimal for application to the stable branch. This should be followed up by more cleanups, but that will involve more work. Fixes: mesonbuild#15361
dcbaker
force-pushed
the
submit/detect-machine-info-for-asm
branch
from
b25e5f0 to
08bf58d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to ensure that we have detailed information on the machine we're targeting. This was previously done by creating an ad hoc info struct, but now we get it from the Environment. This can be a problem if NASM (or MASM, or litearasm) are instantiated before a C compiler, since the information isn't the detailed version yet.
This fixes that by updating the machine info instead.
Fixes: #15361